New Spec: https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-minitest-around.spec
New SRPM: https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-minitest-around-0.3.2-2.fc24.src.rpm

I'm taking this for a review.


* Update to the latest version
  - There seems to be 0.4.0 version available upstream. Please update the package
    to the latest version.

* Integration test suite
  - You have 'rubygem(cucumber)' among your build dependencies, but you don't
    later execute the integration test suite using it. In theory, it should be
    as easy as calling "cucumber" in the %check section. If this is not possible,
    please remove the dependency and explain the reasons.
  - The "features" directory is actually source code of the integration tests
    suite, it should not be required for runtime and hance it belong to -doc
    subpackage (actually you exclude the "test" directory from the package, so
    you probably want to exclude "features" directory as well).
  - The "config" directory looks to be used just by integration test suite, so it
    should follow the same fate as the "features" and "test" directories.

Otherwise the package looks sane. I'll finish the review as soon as you'll update to the latest version.

spec url: https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-minitest-around.spec 
srpm url: https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-minitest-around-0.4.0-1.fc25.src.rpm

- updated to version 0.4.0
- removed from BuildRequires rubygem-cucumber(with cucumber not pass the tests).

(In reply to Ilya Gradina from comment #3)
> - updated to version 0.4.0

Thx

> - removed from BuildRequires rubygem-cucumber(with cucumber not pass the
> tests).

Actually you can run the cucumber test suite. This is the diff I tested:

```
--- rubygem-minitest-around.spec	2016-11-07 14:50:38.050724282 +0100
+++ rubygem-minitest-around.spec.back	2016-11-07 14:49:26.946770370 +0100
@@ -11,6 +11,7 @@
 BuildRequires: ruby(release)
 BuildRequires: rubygems-devel
 BuildRequires: rubygem(minitest)
+BuildRequires: rubygem(cucumber)
 BuildArch: noarch
 
 %description
@@ -54,6 +55,8 @@
 pushd .%{gem_instdir}
   sed -i "/require 'bundler/ s/^/#/" test/helper.rb
   ruby -Ilib -e 'Dir.glob "./test/*_test.rb", &method(:require)'
+
+  RUBYOPT=-Ilib cucumber --tag ~@todo --tag ~@rspec
 popd
 
 %files
```

There are excluded some parts, but these corresponds to the Rakefile [1].

And actually, there are also test/*_spec.rb files which could be executed, so the final patch according to my testing should be:

```
--- rubygem-minitest-around.spec.orig	2016-11-07 15:05:01.312144585 +0100
+++ rubygem-minitest-around.spec	2016-11-07 15:04:43.281157338 +0100
@@ -11,6 +11,7 @@
 BuildRequires: ruby(release)
 BuildRequires: rubygems-devel
 BuildRequires: rubygem(minitest)
+BuildRequires: rubygem(cucumber)
 BuildArch: noarch
 
 %description
@@ -53,7 +54,9 @@
 %check
 pushd .%{gem_instdir}
   sed -i "/require 'bundler/ s/^/#/" test/helper.rb
-  ruby -Ilib -e 'Dir.glob "./test/*_test.rb", &method(:require)'
+  RUBYOPT=-Ilib ruby -e 'Dir.glob "./test/*_{test,spec}.rb", &method(:require)'
+
+  RUBYOPT=-Ilib cucumber --tag ~@todo --tag ~@rspec
 popd
 
 %files
```

The RUBYOPT export is required, -Ilib is not enough, since there are spawned some testing sub processes. In upstream, Bundler takes care about it, but without Bundler, we have to workaround it.


Otherwise the package looks sane => APPROVED but please make sure to enable as much tests as possible.


[1] https://github.com/splattael/minitest-around/blob/master/Rakefile#L37

Hi Vit,

Thx!

new spec: https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-minitest-around.spec
new srpm: https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-minitest-around-0.4.0-2.fc25.src.rpm

- added your fix of the tests
- added run rdoc

(In reply to Ilya Gradina from comment #5)
> - added run rdoc

Would you mind to elaborate the purpose of this?

(In reply to Vít Ondruch from comment #6)
> (In reply to Ilya Gradina from comment #5)
> > - added run rdoc
> 
> Would you mind to elaborate the purpose of this?

Sorry,
I generated the documentation, which is not. Actually this is not the desired action. 

new spec: https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-minitest-around.spec
new srpm: https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-minitest-around-0.4.0-3.fc26.src.rpm

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/rubygem-minitest-around

(In reply to Ilya Gradina from comment #7)
> I generated the documentation, which is not. Actually this is not the
> desired action. 

I thought so. Thx for fixing it :)

rubygem-minitest-around-0.4.0-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-c132f800e5

rubygem-minitest-around-0.4.0-3.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-74a98a3cd8

rubygem-minitest-around-0.4.0-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-74a98a3cd8

rubygem-minitest-around-0.4.0-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-c132f800e5

rubygem-minitest-around-0.4.0-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

rubygem-minitest-around-0.4.0-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.