Bug 1268102
| Summary: | In subman-gui clicking the register button brings up a new registerDialog for each click (even if one is present) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Chris Snyder <csnyder> | ||||||
| Component: | subscription-manager | Assignee: | Alex Wood <awood> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | John Sefler <jsefler> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | high | ||||||||
| Version: | 7.2 | CC: | alikins, bcourt, crog, jmolet, lmiksik, skallesh, stoner | ||||||
| Target Milestone: | rc | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2015-11-19 11:51:16 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Chris Snyder
2015-10-01 20:18:59 UTC
Created attachment 1079282 [details]
multiple registration dialogs
[root@jsefler-7 ~]# rpm -q subscription-manager-gui
subscription-manager-gui-1.15.9-13.el7.x86_64
The same problem exists when clicking the "Auto-attach" button multiple times. There is a little complexity hidden in here. Namely, managergui.MainWindow needs to track the RegisterDialog it creates in the normal approach, but RegisterDialog is not a Widget, so some of the destroy/hide stuff is off by a level. (and some of the object lifetimes are a little complicated, since the dialogs can be hidden, destroy, or they 'finished'). Thinking it might be simplest to block the register button handler when creating RegisterDialog, and connect to the 'finished' signal of the RegisterWidget in RegisterDialog (RegisterDialog.register_dialog.register_widget.register_widget... [2] But maybe more idiomatic to add a 'finished' signal to RegisterDialog, so that managergui.MainWindow would unblock on [this is hard to explain, maybe I can just fix it...] [1] RegisterDialog and it's sub class AutoAttachDialog [2] why? RegisterDialog/RegisterWidget are python classes and GObjects, but are not Gtk.Widget subclasses directly, mostly due to the way the Gtk.Builder() object works [ie, it's a wrapper widget to the actual top level widget from the glade its created from] Another note... the 'Register' menu item can also launch register dialog (and the two are intertwingled in main_window/installedtab). commit 9208977432d286f79d7f470cb06810063390e564
Author: Adrian Likins <alikins>
Date: Fri Oct 2 18:22:19 2015 -0400
Use class methods instead of redundant ad-hoc methods.
commit c4a118b11a2e832ff65c8c92df75bc5fffdfa367
Author: Alex Wood <awood>
Date: Fri Oct 2 15:02:05 2015 -0400
1268102: Stop main window from opening duplicate dialogs.
In upstream master as of the two commits listed above.
Once I clicked the Register button, it became inactive and I was unable to bring up any other register dialogs. [root@dhcp129-49 ~]# rpm -qa | grep subscription subscription-manager-1.15.9-14.el7.x86_64 subscription-manager-gui-1.15.9-14.el7.x86_64 subscription-manager-initial-setup-addon-1.15.9-14.el7.x86_64 Created attachment 1081992 [details]
No multiple register dialogs
Marking verified as I dont see multiple dialogs neither while registering nor auto-attaching .
[root@dhcp35-36 ~]# subscription-manager version
server type: This system is currently not registered.
subscription management server: 2.0.6-1
subscription management rules: 5.17
subscription-manager: 1.15.9-14.el7
python-rhsm: 1.15.4-5.el7
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-2122.html |