Spec URL: https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-http_parser.rb.spec SRPM URL: https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-http_parser.rb-0.6.0-1.fc24.src.rpm Description: Ruby bindings to http://github.com/ry/http-parser and http://github.com/a2800276/http-parser.java. Fedora Account System Username: ilgrad
Let me review this. But if there are any other things to comment, please comment. * spec file - You should add your test suite in %check section. See https://fedoraproject.org/wiki/Packaging:Guidelines#Test_Suites > If the source code of the package provides a test suite, it should be executed in the %check section, whenever it is practical to do so. - rubygem-http_parser is using ruby_http_parser.so compiled by itself. But http_parser package exits in Fedora package. So, should use the package. See http://fedoraproject.org/wiki/Packaging:ReviewGuidelines > MUST: Packages must NOT bundle copies of system libraries * license ok after checking with licensecheck tool. * rpmlint - rpmlint shows below thing. but it looks no problem. rubygem-http_parser.rb.x86_64: E: zero-length /usr/lib64/gems/ruby/http_parser.rb-0.6.0/gem.build_complete - Other warnings looks ok.
(In reply to Jun Aruga from comment #1) > * rpmlint > - rpmlint shows below thing. but it looks no problem. > rubygem-http_parser.rb.x86_64: E: zero-length > /usr/lib64/gems/ruby/http_parser.rb-0.6.0/gem.build_complete This is actually false positive. The file has to be there and has 0 bytes length.
*** This bug has been marked as a duplicate of bug 1372999 ***