Bug 1268881 - Review Request: perl-Coro-Multicore - Make Coro threads on multiple cores with specially supported modules
Summary: Review Request: perl-Coro-Multicore - Make Coro threads on multiple cores wit...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1237116
TreeView+ depends on / blocked
 
Reported: 2015-10-05 14:14 UTC by Petr Pisar
Modified: 2015-10-06 13:11 UTC (History)
2 users (show)

Fixed In Version: perl-Coro-Multicore-0.02-1.fc24
Clone Of:
Environment:
Last Closed: 2015-10-06 13:11:35 UTC
Type: ---
Embargoed:
psabata: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2015-10-05 14:14:33 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Coro-Multicore/perl-Coro-Multicore.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Coro-Multicore/perl-Coro-Multicore-0.02-1.fc24.src.rpm
Description:
While Coro threads (unlike ithreads) provide real threads similar to
pthreads, python threads and so on, they do not run in parallel to each
other even on machines with multiple CPUs or multiple CPU cores.

This module lifts this restriction under two very specific but useful
conditions: firstly, the coro thread executes in XS code and does not
touch any perl data structures, and secondly, the XS code is specially
prepared to allow this.

Fedora Account System Username: ppisar

Comment 1 Petr Šabata 2015-10-05 15:14:48 UTC
* To disable the prompt, you could also use the following option:
  PERL_CANARY_STABILITY_NOPROMPT=1

* Missing a builddep:
  - perl(Coro::AnyEvent), t/01_basic.t:6

* The COPYING file doesn't contain any license text.
  Package it as %doc rather than %license.

* Spell `Coro' with a capital C in the Summary.

* Submit Patch0 upstream.

Comment 2 Petr Pisar 2015-10-05 15:27:32 UTC
Updated package is on the same address.

Comment 3 Petr Šabata 2015-10-05 15:34:02 UTC
Ack, everything addressed.  Approving.

Comment 4 Petr Pisar 2015-10-05 15:39:30 UTC
New Package SCM Request
=======================
Package Name: perl-Coro-Multicore
Short Description: Make Coro threads on multiple cores with specially supported modules
Upstream URL: http://search.cpan.org/dist/Coro-Multicore/
Owners: ppisar jplesnik psabata
Branches: 
InitialCC: perl-sig

Comment 5 Gwyn Ciesla 2015-10-05 23:11:33 UTC
This SCM request method has been deprecated. Please see https://fedoraproject.org/wiki/PackageDB_admin_requests.

Comment 6 Petr Pisar 2015-10-06 07:20:58 UTC
I cannot remember announcement of this deprecation. Moreover is there a command line tool that can request a new package? packagedb-cli-2.9-1.fc22 does not seem to be it.

Comment 7 Petr Pisar 2015-10-06 13:11:35 UTC
Thank you for the review.


Note You need to log in before you can comment on or make changes to this bug.