Bug 1268881 - Review Request: perl-Coro-Multicore - Make Coro threads on multiple cores with specially supported modules
Review Request: perl-Coro-Multicore - Make Coro threads on multiple cores wit...
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Petr Šabata
Fedora Extras Quality Assurance
:
Depends On:
Blocks: 1237116
  Show dependency treegraph
 
Reported: 2015-10-05 10:14 EDT by Petr Pisar
Modified: 2015-10-06 09:11 EDT (History)
2 users (show)

See Also:
Fixed In Version: perl-Coro-Multicore-0.02-1.fc24
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2015-10-06 09:11:35 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
psabata: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Petr Pisar 2015-10-05 10:14:33 EDT
Spec URL: https://ppisar.fedorapeople.org/perl-Coro-Multicore/perl-Coro-Multicore.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Coro-Multicore/perl-Coro-Multicore-0.02-1.fc24.src.rpm
Description:
While Coro threads (unlike ithreads) provide real threads similar to
pthreads, python threads and so on, they do not run in parallel to each
other even on machines with multiple CPUs or multiple CPU cores.

This module lifts this restriction under two very specific but useful
conditions: firstly, the coro thread executes in XS code and does not
touch any perl data structures, and secondly, the XS code is specially
prepared to allow this.

Fedora Account System Username: ppisar
Comment 1 Petr Šabata 2015-10-05 11:14:48 EDT
* To disable the prompt, you could also use the following option:
  PERL_CANARY_STABILITY_NOPROMPT=1

* Missing a builddep:
  - perl(Coro::AnyEvent), t/01_basic.t:6

* The COPYING file doesn't contain any license text.
  Package it as %doc rather than %license.

* Spell `Coro' with a capital C in the Summary.

* Submit Patch0 upstream.
Comment 2 Petr Pisar 2015-10-05 11:27:32 EDT
Updated package is on the same address.
Comment 3 Petr Šabata 2015-10-05 11:34:02 EDT
Ack, everything addressed.  Approving.
Comment 4 Petr Pisar 2015-10-05 11:39:30 EDT
New Package SCM Request
=======================
Package Name: perl-Coro-Multicore
Short Description: Make Coro threads on multiple cores with specially supported modules
Upstream URL: http://search.cpan.org/dist/Coro-Multicore/
Owners: ppisar jplesnik psabata
Branches: 
InitialCC: perl-sig
Comment 5 Gwyn Ciesla 2015-10-05 19:11:33 EDT
This SCM request method has been deprecated. Please see https://fedoraproject.org/wiki/PackageDB_admin_requests.
Comment 6 Petr Pisar 2015-10-06 03:20:58 EDT
I cannot remember announcement of this deprecation. Moreover is there a command line tool that can request a new package? packagedb-cli-2.9-1.fc22 does not seem to be it.
Comment 7 Petr Pisar 2015-10-06 09:11:35 EDT
Thank you for the review.

Note You need to log in before you can comment on or make changes to this bug.