Bug 1269676 - Review Request: nodejs-type-is - Infer the content-type of a request
Summary: Review Request: nodejs-type-is - Infer the content-type of a request
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Piotr Popieluch
QA Contact: Fedora Extras Quality Assurance
Depends On: 1269670 1269672
Blocks: nodejs-reviews Node-RED
TreeView+ depends on / blocked
Reported: 2015-10-07 22:38 UTC by Jared Smith
Modified: 2016-10-21 08:13 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2016-05-27 20:15:07 UTC
Type: ---
piotr1212: fedora-review+

Attachments (Terms of Use)

Description Jared Smith 2015-10-07 22:38:06 UTC
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-type-is/nodejs-type-is.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-type-is/nodejs-type-is-1.6.9-1.fc23.src.rpm
Description: Infer the content-type of a request
Fedora Account System Username: jsmith

$ rpmlint nodejs-type-is.spec nodejs-type-is-1.6.9-1.fc23.src.rpm 
1 packages and 1 specfiles checked; 0 errors, 0 warnings.

Depends on nodejs-media-typer from bug #1269672 and nodejs-mime-types from bug #1269670.

Comment 1 Piotr Popieluch 2015-12-06 13:19:54 UTC
Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "MIT/X11 (BSD like)", "Unknown or generated". 6 files have
     unknown license. Detailed output of licensecheck in
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

Checking: nodejs-type-is-1.6.9-1.fc24.noarch.rpm
nodejs-type-is.noarch: W: only-non-binary-in-usr-lib
nodejs-type-is.noarch: W: dangling-symlink /usr/lib/node_modules/type-is/node_modules/media-typer /usr/lib/node_modules/media-typer
nodejs-type-is.noarch: W: dangling-symlink /usr/lib/node_modules/type-is/node_modules/mime-types /usr/lib/node_modules/mime-types
2 packages and 0 specfiles checked; 0 errors, 3 warnings.

Rpmlint (installed packages)
sh: /usr/bin/python: No such file or directory
nodejs-type-is.noarch: W: only-non-binary-in-usr-lib
nodejs-type-is.noarch: W: dangling-symlink /usr/lib/node_modules/type-is/node_modules/media-typer /usr/lib/node_modules/media-typer
nodejs-type-is.noarch: W: dangling-symlink /usr/lib/node_modules/type-is/node_modules/mime-types /usr/lib/node_modules/mime-types
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

nodejs-type-is (rpmlib, GLIBC filtered):


Source checksums
https://github.com/jshttp/type-is/archive/1.6.9.tar.gz :
  CHECKSUM(SHA256) this package     : c686896ea3cf3f46dd217b5bb2f2a58abc5a87e0382fc7ea6fb0970ed7071713
  CHECKSUM(SHA256) upstream package : c686896ea3cf3f46dd217b5bb2f2a58abc5a87e0382fc7ea6fb0970ed7071713

Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -b 1269676
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby

Comment 2 Piotr Popieluch 2015-12-06 13:21:06 UTC
Approved, but please update to latest version before importing into SCM.

Comment 3 Gwyn Ciesla 2015-12-07 17:38:49 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/nodejs-type-is

Comment 4 Piotr Popieluch 2016-05-27 20:15:07 UTC
built in rawhide and f24, closing.

Note You need to log in before you can comment on or make changes to this bug.