Description of problem: The dht_migrate_file function currently does not move the POSIX locks on the file being migrated to the dst file. Any locks held on a file are lost once the migration is complete. This problem exists in DHT rebalance but is magnified in tiering as promotes and demotes occur more frequently. BZ 1267955 tracks the lock migration fix. Until that is done, we will skip all files on which POSIX locks are held. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
REVIEW: http://review.gluster.org/12347 (cluster/dht : Do not migrate files with POSIX locks held) posted (#1) for review on master by N Balachandran (nbalacha)
REVIEW: http://review.gluster.org/12347 (cluster/dht : Do not migrate files with POSIX locks held) posted (#2) for review on master by N Balachandran (nbalacha)
REVIEW: http://review.gluster.org/12347 (cluster/dht : Do not migrate files with POSIX locks held) posted (#3) for review on master by N Balachandran (nbalacha)
COMMIT: http://review.gluster.org/12347 committed in master by Dan Lambright (dlambrig) ------ commit bd71446b25aefe066ca18a28d73d777774ab7f87 Author: N Balachandran <nbalacha> Date: Tue Oct 13 15:02:00 2015 +0530 cluster/dht : Do not migrate files with POSIX locks held dht_migrate_file does not migrate file locks to the dst file. Any locks held on the source file are lost once the migration is complete. This issue is magnified in the case of a tier volume as file migrations occur more frequently and repeatedly as compared to a DHT rebalance. The fix makes 2 changes: 1. Before starting the actual migration process, check if there are any locks held on the file. If yes, do not migrate the file. 2. The rebalance process tries to lock on the entire file just before moving into the Phase 2 of the file migration. If the lock acquisition fails, the file migration does not proceed. If the lock is granted, the file migration proceeds. This still leaves a small window where conflicting locks can be granted to different clients. If client1 requests a lock on the src file just after it is converted to a linkto file and client2 requests a lock on the dst data file, they will both be granted, but all FOPs will be redirected to the dst data file. This issue will be taken up in a subsequent patch. Change-Id: I8c895fc3cced50dd2894259d40a827c7b43d58ac BUG: 1271148 Signed-off-by: N Balachandran <nbalacha> Reviewed-on: http://review.gluster.org/12347 Tested-by: NetBSD Build System <jenkins.org> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Dan Lambright <dlambrig> Tested-by: Dan Lambright <dlambrig>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report. glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/ [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user