Bug 127164 - mc hangs with directory names with newline inside (with subshell enabled)
Summary: mc hangs with directory names with newline inside (with subshell enabled)
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: mc
Version: 2
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jindrich Novy
QA Contact:
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2004-07-02 21:16 UTC by Doncho Gunchev
Modified: 2013-07-02 23:00 UTC (History)
2 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2004-10-11 12:20:27 UTC


Attachments (Terms of Use)
Output of lsof at the time of the hang. (1.77 KB, text/plain)
2004-11-18 10:43 UTC, Pavel Tsekov
no flags Details

Description Doncho Gunchev 2004-07-02 21:16:17 UTC
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040627

Description of problem:
If I create a directory with newline (yes, quite unusual) inside,
enter this directory and then start mc, that's the last thing I can
do, it hangs and only kill <mc_pid> helps.

Version-Release number of selected component (if applicable):
mc-4.6.0-15

How reproducible:
Always

Steps to Reproduce:
1. A=$(echo -ne 'newline\ndir')
2. mkdir "$A"
3. cd "$A"
4. mc
5. press <TAB>

Actual Results:  mc hangs there when you try to change the dir or
switcg the panels.

Expected Results:  Such directory should be displayed like in ls ('?'
instead new line or whatever), but not hang mc.

Additional info:

    I've tested this with RH9, FC1 (text and graphical console) and
FC2 with UTF-8 and without. Even the Leonard den Ottolander's patched
version (mc-4.6.0-14.10n) nothing changes for me. If I run mc with
ltrace: 'ltrace mc 2> ZZZ' it seems to work (slow, verry slow but
works), but with 'strace mc 2> ZZZ' it hangs again and in the log
there's probably something usefull I did not find. When used without
concurrent shell (mc -u) everything works fine (but the newline
character is simply ignored when showing the path).
    I suspect there can be other weird characters that can hang or
even crash mc, but I have not tested this yet.

Comment 1 Jindrich Novy 2004-10-11 12:20:27 UTC
This is now fixed in rawhide.

Jindrich

Comment 2 Pavel Tsekov 2004-11-18 10:43:42 UTC
Created attachment 106947 [details]
Output of lsof at the time of the hang.

Comment 3 Pavel Tsekov 2004-11-18 10:45:36 UTC
The patch is not good enough. It causes MC to hang when the subshell
is tcsh, as can be seen from this strace:

9770 pts/0    S+     0:00 /home/ptsekov/mc-test/usr/bin/mc -U
9773 pts/5    Ts+    0:00 -csh

[ptsekov@baba-meca abcdef]$ strace -p 9770
Process 9770 attached - interrupt to quit
read(6,

See also the lsof output.


Comment 4 Leonard den Ottolander 2005-05-18 13:34:42 UTC
Which patch would this be again?


Comment 5 Jindrich Novy 2005-05-18 13:58:44 UTC
This is the "uglydir" patch you can see in our src.rpm.


Note You need to log in before you can comment on or make changes to this bug.