Bug 1271785 - Review Request: nodejs-bcryptjs - bcrypt encryption for NodeJS
Review Request: nodejs-bcryptjs - bcrypt encryption for NodeJS
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Robert-André Mauchin
Fedora Extras Quality Assurance
Depends On: 1354009 1354014 1354016 1354018
Blocks: nodejs-reviews Node-RED
  Show dependency treegraph
Reported: 2015-10-14 13:49 EDT by Jared Smith
Modified: 2017-09-27 08:49 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2017-09-27 08:49:16 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
zebob.m: fedora‑review+

Attachments (Terms of Use)

  None (edit)
Description Jared Smith 2015-10-14 13:49:49 EDT
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-bcrypt/nodejs-bcryptjs.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-bcrypt/nodejs-bcryptjs-2.3.0-1.fc23.src.rpm
Description: Optimized bcrypt in plain JavaScript with zero dependencies
Fedora Account System Username: jsmith
Comment 1 Piotr Popieluch 2015-10-27 08:32:37 EDT
I've only taken a quick look but it seems that the packaged files are generated/compiled. I think this should be built from source with closurecompiler.
Comment 2 Piotr Popieluch 2015-11-30 03:07:24 EST
ok, closurecompiler is only needed for generating the minified js intended for browser use. You can skip that if you only intend to run it in nodejs. But you will have to use (and package) metascript to build the package.\

"build": "node scripts/build.js",


The %install section is missing some needed directories.
Comment 3 Jared Smith 2016-07-08 14:10:50 EDT
Finnally making progress on this -- it's got a bunch of newer dependencies, but should be in much better shape now.

Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-bcryptjs/nodejs-bcryptjs.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-bcryptjs/nodejs-bcryptjs-2.3.0-1.fc24.src.rpm
Comment 4 Piotr Popieluch 2016-09-29 17:21:49 EDT
Seems that the source has multiple licenses, they all need to be specified.

dist dir needs to be installed. Binary as well. Not sure about externs dir.

%nodejs_symlink_deps --check
                     ^^ shouldn't this be --build

%{!?_licensedir:%global license %doc}
These macros are not needed anymore

tests seem to be included in npm package now. Is the separate download still needed?
Comment 7 Robert-André Mauchin 2017-09-23 09:51:53 EDT
Everything seems good, package accepted.
Comment 8 Jared Smith 2017-09-24 20:41:15 EDT
'Requested package in ticket https://pagure.io/releng/fedora-scm-requests/issue/1596'
Comment 9 Gwyn Ciesla 2017-09-25 09:01:21 EDT
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-bcryptjs
Comment 10 Jared Smith 2017-09-27 08:49:16 EDT
In rawhide, closing bug

Note You need to log in before you can comment on or make changes to this bug.