Bug 1272239 - Errors in GUI thrown by JVM parameters in cassandra-jvm.properties.new having " char in them
Summary: Errors in GUI thrown by JVM parameters in cassandra-jvm.properties.new having...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Operations Network
Classification: JBoss
Component: Storage Node
Version: JON 3.3.4
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: CR01
: JON 3.3.4
Assignee: Michael Burman
QA Contact: Mike Foley
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-10-15 20:35 UTC by Vojta Prusa
Modified: 2015-10-29 15:55 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
RHEL 7.1 Server and agent registered
Last Closed: 2015-10-29 15:55:47 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Vojta Prusa 2015-10-15 20:35:33 UTC
Description of problem:
After applying JON 3.3.4 ER2 patch ( download.devel.redhat.com/brewroot/packages/org.jboss.on-jboss-on-parent/3.3.0.GA/66/maven/org/jboss/on/jon-server-patch/3.3.0.GA/jon-server-patch-3.3.0.GA.zip )
In file ./jon-server-3.3.0.GA/rhq-storage/conf/cassandra-jvm.properties.new
parameters:

heap_min="-Xms256M"
heap_max="-Xms256M"
heap_new="-Xmn64M"

throws error in GUI:

The following configuration properties have invalid values: [Max Heap Size, Heap New Size, Thread Stack Size]. The values must be corrected before the configuration can be saved.

And Min Heap Size, Max Heap Size, Heap New Size have Quote chars in its input fields: 	
"-Xms256M"
I suppose " char is the problem.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Update JON server
2. Update new cassandra node properties: cp ./jon-server-3.3.0.GA/rhq-storage/conf/cassandra-jvm.properties.new ./jon-server-3.3.0.GA/rhq-storage/conf/cassandra-jvm.properties
3. Changed parameters to:
thread_stack_size="-Xss256k"
JMX_OPTS="-Djava.rmi.server.hostname=localhost -Dcom.sun.management.jmxremote.port=${jmx_port} -Dcom.sun.management.jmxremote.ssl=false -Dcom.sun.management.jmxremote.authenticate=false"
4. Start JON server: ./jon-server-3.3.0.GA/bin/rhqctl start
5. In GUI go to Inventory -> Servers - Top level imports -> RHQ Storage Node* -> Configuration


Actual results:


Expected results:


Additional info:
Found when verifying https://bugzilla.redhat.com/show_bug.cgi?id=1259555 and so far using cassandra-jvm.properties.new throws errors on JON server start (./rhqctl start) may be my mistake in configuration but probably more bugs will follow and be linked to this one.
Also: Why step 3)? Reason: This have something to do with https://bugzilla.redhat.com/show_bug.cgi?id=1259555 and im still testing it.

Comment 1 Simeon Pinder 2015-10-24 11:00:06 UTC
This is fixed with the following commit to jon.git:
45b07bd25d9e8b

All of the newest quoted strings, that were added in error, have been removed.  More specifically, the new JVM_OPTS line should replace the old one when customers/users are merging this .new file with their own version.

Comment 2 Simeon Pinder 2015-10-24 11:09:15 UTC
Moving to ON_QA as available for test in latest brew build:
https://brewweb.devel.redhat.com/buildinfo?buildID=462976

*Note* jon-server-patch-3.3.0.GA.zip from above maps to CR01 build of JON 3.3.4.

Comment 3 Filip Brychta 2015-10-26 12:10:57 UTC
Verified on
Version :	
3.3.0.GA Update 04
Build Number :	
e9ed05b:aa79ebd


Note You need to log in before you can comment on or make changes to this bug.