Fedora Account System
Red Hat Associate
Red Hat Customer
Created attachment 1084194 [details] patch, tested with openbios. Description of problem: Trying to compile openbios on Fedora 22 ppc64, I had the following error: toke -o QEMU,VGA.bin ~/openbios/drivers/vga.fs ... Tokenizing ~/openbios/drivers/vga.fs Binary output to QEMU,VGA.bin Warning: File ~/openbios/drivers/vga.fs, Line 1. Unterminated comment Nothing Tokenized. 1 Warning. This can be reproduced with the fcode-utils examples. Version-Release number of selected component (if applicable): fcode-utils-1.0.2-11.fc22 How reproducible: 100% Steps to Reproduce: 1. Download the fcode-utils source package 2. cd fcode-utils/toke 3. toke examples/case.fs Actual results: Tokenizing examples/case.fs Binary output to examples/case.fc Warning: File examples/case.fs, Line 1. Unterminated comment Nothing Tokenized. 1 Warning. Expected results: Tokenizing examples/case.fs Binary output to examples/case.fc Tokenization Completed. . toke: wrote 67 bytes to bytecode file 'examples/case.fc' Additional info: "toke" is parsing the comment line until it finds a '\n'. The '\n' is stored in char which is a field in an union, but it is read as a long. It works well on little endian but not on big endian.
Fixed upstream by: http://tracker.coreboot.org/trac/openbios/changeset/1354
fcode-utils-1.0.2-13.svn1354.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-9f055e78f8
fcode-utils-1.0.2-13.svn1354.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-9f055e78f8
fcode-utils-1.0.2-13.svn1354.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-0bf8cc878f
fcode-utils-1.0.2-13.svn1354.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
fcode-utils-1.0.2-13.svn1354.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.