Bug 1273302 - beaker-log-delete does not delete old jobs if they have no finish time (e.g. Cancelled or Aborted)
Summary: beaker-log-delete does not delete old jobs if they have no finish time (e.g. ...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Beaker
Classification: Retired
Component: general
Version: 21
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: 22.0
Assignee: Dan Callaghan
QA Contact: tools-bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-10-20 07:48 UTC by Dan Callaghan
Modified: 2016-01-14 05:32 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-01-14 05:32:56 UTC
Embargoed:


Attachments (Terms of Use)

Description Dan Callaghan 2015-10-20 07:48:00 UTC
Description of problem:
If a recipe is Cancelled or Aborted before it ever starts, the finish_time will remain NULL. If that happens, the job will be excluded from beaker-log-delete's regular deletion process because it is filtering based on finish_time.

Version-Release number of selected component (if applicable):
21.1

How reproducible:
we have heaps on beaker-devel

Steps to Reproduce:
1. Create a job with "scratch" retention tag, and then cancel it before it can start the recipe -- finish time should be NULL
2. Wait 30 days *or* if lazy, hack the value of the recipeset.queue_time column in the database to be 30 days in the past
3. Run beaker-log-delete on the server

Actual results:
beaker-log-delete ignores the old cancelled job

Expected results:
Old Cancelled and Aborted jobs should be deleted

Comment 1 Dan Callaghan 2015-10-20 07:49:11 UTC
Correction... we *had* examples of this on beaker-devel but I tested out my patch on there and so there are deleted already. :-)

Comment 2 Dan Callaghan 2015-10-21 06:47:16 UTC
http://gerrit.beaker-project.org/4449

Comment 5 Dan Callaghan 2016-01-14 05:32:56 UTC
Beaker 22.0 has been released.


Note You need to log in before you can comment on or make changes to this bug.