Bug 1273486 - [SR-IOV] - Block Hotplug/unplug 'pci-passthrough' vNIC types on 3.6
Summary: [SR-IOV] - Block Hotplug/unplug 'pci-passthrough' vNIC types on 3.6
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Network
Version: 3.6.0
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ovirt-3.6.1
: 3.6.1
Assignee: Alona Kaplan
QA Contact: Michael Burman
URL:
Whiteboard: network
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-10-20 14:29 UTC by Michael Burman
Modified: 2016-02-10 19:16 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-12-16 12:19:46 UTC
oVirt Team: Network
Embargoed:
rule-engine: ovirt-3.6.z+
ylavi: Triaged+
ylavi: planning_ack+
rule-engine: devel_ack+
rule-engine: testing_ack+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 48439 0 master MERGED engine: Block Hotplug/unplug 'pci-passthrough' vNIC types Never
oVirt gerrit 48595 0 ovirt-engine-3.6 MERGED engine: Block Hotplug/unplug 'pci-passthrough' vNIC types Never

Description Michael Burman 2015-10-20 14:29:32 UTC 
Description of problem:
[SR-IOV] - Block Hotplug/unplug 'pci-passthrough' vNIC types on 3.6.

Since this BZ 1234328 will be done only for 4.0, Hotplug/unplug 'pci-passthrough' vNICs type must be blocked on 3.6.
This is causing a lot of issues as it not blocked on 3.6.
If user by mistake Hotplug/unplug 'pci-passthrough' vNIC type while the VM is running, it will cause several issues. 
Some of VFs could be considered as non-free VFs on host, while they actually free and to some more issues related to sr-iov.
Comment 1 Yaniv Lavi 2015-10-29 12:47:46 UTC 
In oVirt testing is done on single release by default. Therefore I'm removing the 4.0 flag. If you think this bug must be tested in 4.0 as well, please re-add the flag. Please note we might not have testing resources to handle the 4.0 clone.
Comment 2 Michael Burman 2015-11-29 11:26:48 UTC 
Verified on - 3.6.1-0.2.el6 

Note that in this point we have 2 different validations:

1) Is the network attached to host? 
Although it's not relevant for 'passthrough' networks, this validation taking place because the Hotplug/unplug passthrough vNICs is not supported on 3.6
 
"Error while executing action: 

sr-vm1:
The Network does not exist on the host the VM is running on.
Either add the Network to the Host or migrate the VM to a Host that has this Network."

- For DEV + QA --> this validation should be skipped on 4.0/when Hotplug/unplug will be supported, cause it's not relevant to 'passthorugh' networks.
We shouldn't see such error messages ^^ for 'passthrough' networks.

2) If the network attached to host, is it a 'passthrough' one? if yes, then Hotplug/unplug is not supported on 3.6 -->

"Error while executing action: 

sr-vm1:
Cannot add Interface. Hot plugging/unplugging of passthrough virtual machine network interface is not supported."

This was discussed and agreed with DEV, no matter if the 'passthrough' network is attached or not to host, user/admin won't be able to Hotplug/unplug 'pci-passthrough' vNICs to running VM/s and that is the desired behavior for 3.6
Comment 3 Sandro Bonazzola 2015-12-16 12:19:46 UTC 
According to verification status and target milestone this issue should be fixed in oVirt 3.6.1. Closing current release.
Note You need to log in before you can comment on or make changes to this bug.