Bug 1273500 - Inconsistent state after SIGINT during eval
Summary: Inconsistent state after SIGINT during eval
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: tcsh
Version: 7.2
Hardware: x86_64
OS: Linux
Target Milestone: rc
: ---
Assignee: David Kaspar [Dee'Kej]
QA Contact: Iveta Wiedermann
Depends On: 1219923
Blocks: 1203710 1313485 1289025 1295829
TreeView+ depends on / blocked
Reported: 2015-10-20 15:05 UTC by David Kaspar [Dee'Kej]
Modified: 2019-10-10 10:22 UTC (History)
5 users (show)

Fixed In Version: tcsh-6.18.01-10.el7
Doc Type: Bug Fix
Doc Text:
*tcsh* no longer in an inconsistent state after a command interruption Interrupting the "eval sleep 10" command left the *tcsh* shell in an incosistent state. Consequently, it was necessary to press the Ctrl+D key combination twice to successfully exit the shell. With this update, *tcsh* correctly exits after pressing Ctrl+D once.
Clone Of: 1219923
Last Closed: 2016-11-04 01:46:10 UTC
Target Upstream Version:

Attachments (Terms of Use)

System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:2260 0 normal SHIPPED_LIVE tcsh bug fix update 2016-11-03 13:32:41 UTC

Description David Kaspar [Dee'Kej] 2015-10-20 15:05:54 UTC
+++ This bug was initially created as a clone of Bug #1219923 +++

Description of problem (quoting cloned bug description):

This was reported to upstream:


An user reported a problem, that apparently happens for quite
some time.

The user reports that interrupting this command:

eval sleep 10

would keep history in tcsh-6.14.00, but not in tcsh-6.18.01.
Actually, I believe the history not being logged is due to

and the problem is another, as the inconsistent state
happens in all tcsh versions. Basically, when doeval()
calls process(), process() does not leave, so one needs
to ^D twice to get back to the consistent state.

The attached patch correct this condition, and based
on code I could read is correct, but I would like some
feedback on it.



Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. run 'tcsh'.
2. run command:
> eval sleep 10
3. press <Ctrl-C> during that time
4. press <Ctrl-D> to close the terminal

Actual results:
You have to press <Ctrl-D> once again to actually exit the terminal.

Expected results:
The 'tcsh' exits normally after first pressing of <Ctrl-D>.

--- Additional comment from Paulo Andrade on 2015-05-09 08:59:43 EDT ---

Update patch, as initially proposed patch would
break the shell (was exiting if pressing ^C),
while the idea was to just leave the inconsistent
state after ^C during eval.

--- Additional comment from Fridolín Pokorný on 2015-05-13 08:31:13 EDT ---

Thanks for the report and provided patch!

It looks OK to me and it sounds reasonable to merge this patch, no fail noted in upstream testsuite as well.

--- Additional comment from David Kaspar [Dee'Kej] on 2015-10-20 07:12:21 EDT ---

Here is the mailing list conversation mentioned in the comment #0:

--- Additional comment from David Kaspar [Dee'Kej] on 2015-10-20 07:22:03 EDT ---

The conversation in the mailing list might be misleading to somebody - it might look like the patch was not accepted:

> And removed. This breaks the shell completely; a ^C makes it exit.
> christos

However, will small tweak, the patch was accepted by the upstream:

Comment 6 errata-xmlrpc 2016-11-04 01:46:10 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.