Hide Forgot
Description of problem: I got the following traceback when running kickstart installation in VNC mode on an s390x system with unformatted DASD disk: anaconda 23.19.7-1 exception report Traceback (most recent call first): File "/usr/lib64/python3.4/site-packages/gi/overrides/BlockDev.py", line 395, in wrapped ret = orig_obj(*args, **kwargs) File "/usr/lib64/python3.4/site-packages/pyanaconda/ui/gui/spokes/storage.py", line 710, in run_dasdfmt blockdev.s390.dasd_format(disk) File "/usr/lib64/python3.4/threading.py", line 868, in run self._target(*self._args, **self._kwargs) File "/usr/lib64/python3.4/site-packages/pyanaconda/threads.py", line 253, in run threading.Thread.run(self, *args, **kwargs) TypeError: Must be string, not DASDDevice Version-Release number of selected component (if applicable): http://s390pkgs.fedoraproject.org/compose/23_TC1/23/Server/s390x/os/ anaconda-23.19.7-1.fc23 python-blivet-1.12.7-1.fc23 How reproducible: always Steps to Reproduce: 1. have an unformatted DASD disk (or format one DASD disk with cpfmtxa in CMS) 2. start kickstart installation in VNC mode, the ks file contains: vnc bootloader --location=mbr zerombr clearpart --all --initlabel autopart Actual results: anaconda traceback Expected results: unformatted DASD disk is formatted with dasdfmt and the installation finishes successfully
This is again a very easy (one-line) fix isolated strictly to s390x code.
Proposed as a Freeze Exception for 23-final by Fedora user jstodola using the blocker tracking app because: Violating the following criteria: https://fedoraproject.org/wiki/Fedora_23_Beta_Release_Criteria#Unattended_installation https://fedoraproject.org/wiki/Fedora_23_Final_Release_Criteria#Disk_layouts Proposing as an exception, since this is only happening on s390x (secondary architecture)
Posted patch for review; even if it is rejected as a FE it needs to still get fixed in master.
+1 FE, critical issue for s390 and it's clearly restricted to the DASD path in the code. Patch is https://lists.fedorahosted.org/pipermail/anaconda-patches/2015-October/024925.html
+1 FE.
+1 FE
That's +3, accepted.
Thanks, guys.
python-blivet-1.12.8-1.fc23 anaconda-23.19.9-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-da7ada8825
It is fixed in anaconda-23.19.9-1.fc23, the installation finished successfully and an unformatted DASD was formatted with dasdfmt during the installation. Thanks, moving to VERIFIED.
anaconda-23.19.10-1.fc23, python-blivet-1.12.8-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update anaconda python-blivet' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-da7ada8825
Closing as fixed (see comment 11).
...except the update has not been pushed stable.
anaconda-23.19.10-1.fc23, python-blivet-1.12.8-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.