Bug 1273553 - TypeError: Must be string, not DASDDevice
Summary: TypeError: Must be string, not DASDDevice
Alias: None
Product: Fedora
Classification: Fedora
Component: anaconda
Version: 23
Hardware: s390x
OS: Linux
Target Milestone: ---
Assignee: Samantha N. Bueno
QA Contact: Fedora Extras Quality Assurance
Whiteboard: AcceptedFreezeException
Depends On:
Blocks: ZedoraTracker F23FinalFreezeException
TreeView+ depends on / blocked
Reported: 2015-10-20 16:53 UTC by Jan Stodola
Modified: 2015-10-26 21:01 UTC (History)
9 users (show)

Fixed In Version: anaconda-23.19.9-1 anaconda-23.19.10-1.fc23
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2015-10-26 21:01:20 UTC
Type: Bug

Attachments (Terms of Use)

Description Jan Stodola 2015-10-20 16:53:49 UTC
Description of problem:
I got the following traceback when running kickstart installation in VNC mode on an s390x system with unformatted DASD disk:

anaconda 23.19.7-1 exception report
Traceback (most recent call first):
  File "/usr/lib64/python3.4/site-packages/gi/overrides/BlockDev.py", line 395, in wrapped
    ret = orig_obj(*args, **kwargs)
  File "/usr/lib64/python3.4/site-packages/pyanaconda/ui/gui/spokes/storage.py", line 710, in run_dasdfmt
  File "/usr/lib64/python3.4/threading.py", line 868, in run
    self._target(*self._args, **self._kwargs)
  File "/usr/lib64/python3.4/site-packages/pyanaconda/threads.py", line 253, in run
    threading.Thread.run(self, *args, **kwargs)
TypeError: Must be string, not DASDDevice

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. have an unformatted DASD disk (or format one DASD disk with cpfmtxa in CMS)
2. start kickstart installation in VNC mode, the ks file contains:

bootloader --location=mbr
clearpart --all --initlabel

Actual results:
anaconda traceback

Expected results:
unformatted DASD disk is formatted with dasdfmt and the installation finishes successfully

Comment 2 Samantha N. Bueno 2015-10-20 16:56:22 UTC
This is again a very easy (one-line) fix isolated strictly to s390x code.

Comment 3 Fedora Blocker Bugs Application 2015-10-20 17:08:37 UTC
Proposed as a Freeze Exception for 23-final by Fedora user jstodola using the blocker tracking app because:

 Violating the following criteria:


Proposing as an exception, since this is only happening on s390x (secondary architecture)

Comment 4 Samantha N. Bueno 2015-10-20 17:34:02 UTC
Posted patch for review; even if it is rejected as a FE it needs to still get fixed in master.

Comment 5 Adam Williamson 2015-10-20 17:46:21 UTC
+1 FE, critical issue for s390 and it's clearly restricted to the DASD path in the code. Patch is https://lists.fedorahosted.org/pipermail/anaconda-patches/2015-October/024925.html

Comment 6 Kevin Fenzi 2015-10-20 17:47:25 UTC
+1 FE.

Comment 7 Mike Ruckman 2015-10-20 18:04:49 UTC
+1 FE

Comment 8 Adam Williamson 2015-10-20 18:12:52 UTC
That's +3, accepted.

Comment 9 Samantha N. Bueno 2015-10-21 17:24:34 UTC
Thanks, guys.

Comment 10 Fedora Update System 2015-10-21 18:32:20 UTC
python-blivet-1.12.8-1.fc23 anaconda-23.19.9-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-da7ada8825

Comment 11 Jan Stodola 2015-10-23 05:50:18 UTC
It is fixed in anaconda-23.19.9-1.fc23, the installation finished successfully and an unformatted DASD was formatted with dasdfmt during the installation.
Thanks, moving to VERIFIED.

Comment 12 Fedora Update System 2015-10-24 12:08:53 UTC
anaconda-23.19.10-1.fc23, python-blivet-1.12.8-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update anaconda python-blivet'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-da7ada8825

Comment 13 Jan Stodola 2015-10-26 08:55:56 UTC
Closing as fixed (see comment 11).

Comment 14 Adam Williamson 2015-10-26 16:55:16 UTC
...except the update has not been pushed stable.

Comment 15 Fedora Update System 2015-10-26 21:00:45 UTC
anaconda-23.19.10-1.fc23, python-blivet-1.12.8-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.