Spec URL: https://pwu.fedorapeople.org/fonts/google-noto-cjk-fonts/google-noto-cjk-fonts.spec SRPM URL: https://pwu.fedorapeople.org/fonts/google-noto-cjk-fonts/google-noto-cjk-fonts-1.004-1.fc22.src.rpm Description: Google Noto Sans CJK Fonts Fedora Account System Username:pwu
Issues: 1) if you run rpmlint on source rpm only then you will see google-noto-cjk-fonts.src: E: description-line-too-long C Noto Sans CJK is a sans serif typeface designed as an intermediate style between the modern and traditional. It is intended to be a multi-purpose digital font for user interface designs, digital content, reading on laptops, mobile devices, and electronic books. Noto Sans CJK comprehensively covers Simplified Chinese, Traditional Chinese, Japanese, and Korean in a unified font family. It supports regional variants of ideographic characters for each of the four languages. In addition, it supports Japanese kana, vertical forms, and variant characters (itaiji); it supports Korean hangeul — both contemporary and archaic. google-noto-cjk-fonts.src: W: no-version-in-last-changelog google-noto-cjk-fonts.src:81: E: use-of-RPM_SOURCE_DIR Fix these 3 issues. You need to split common_desc line to 80 char limit multiple lines. You missed the version in changelog then instead of sourcedir macro try builddir macro 2) removal of buildroot in %install, then %clean section are optional and can be removed. 3) I don't think it makes sense to create -common subpackage just for LICENSE file. Instead drop it and add %doc LICENSE to every binary rpm. 4) We need to follow git source guidelines. See https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Hosting_Services Add in spec at top %global commit0 40-CHARACTER-HASH-VALUE %global shortcommit0 %(c=%{commit0}; echo ${c:0:7}) then Source0: https://github.com/OWNER/%{name}/archive/%{commit0}.tar.gz#/%{name}-%{shortcommit0}.tar.gz and in %prep %setup -qn %{name}-%{commit0}
Spec URL: https://pwu.fedorapeople.org/fonts/google-noto-cjk-fonts/google-noto-cjk-fonts.spec SRPM URL: https://pwu.fedorapeople.org/fonts/google-noto-cjk-fonts/google-noto-cjk-fonts-1.004-2.fc22.src.rpm Please review it again, thanks.
Spec URL: https://pwu.fedorapeople.org/fonts/google-noto-cjk-fonts/google-noto-cjk-fonts.spec SRPM URL: https://pwu.fedorapeople.org/fonts/google-noto-cjk-fonts/google-noto-cjk-fonts-1.004-2.fc23.src.rpm Please review it again, thanks.
Looks good. Only last thing is to add per subpackage %doc NEWS HISTORY README.formats README.third_party APPROVED.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/google-noto-cjk-fonts
google-noto-cjk-fonts-1.004-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-af6af4d9e1
google-noto-cjk-fonts-1.004-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update google-noto-cjk-fonts' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-7ce4b37c4f
google-noto-cjk-fonts-1.004-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update google-noto-cjk-fonts' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-af6af4d9e1
google-noto-cjk-fonts-1.004-3.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-408257aebc
google-noto-cjk-fonts-1.004-3.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update google-noto-cjk-fonts' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-408257aebc
google-noto-cjk-fonts-1.004-3.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update google-noto-cjk-fonts' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-0940977659
google-noto-cjk-fonts-1.004-3.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
google-noto-cjk-fonts-1.004-3.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.