Bug 1274101 - need a way to pause/stop tiering to take snapshot
Summary: need a way to pause/stop tiering to take snapshot
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: tiering
Version: 3.7.6
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Dan Lambright
QA Contact: bugs@gluster.org
URL:
Whiteboard:
Depends On: 1267950 1274334
Blocks: 1260923 glusterfs-3.7.6
TreeView+ depends on / blocked
 
Reported: 2015-10-21 23:02 UTC by Dan Lambright
Modified: 2015-11-17 06:01 UTC (History)
3 users (show)

Fixed In Version: glusterfs-3.7.6
Clone Of: 1267950
Environment:
Last Closed: 2015-11-17 06:01:01 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Dan Lambright 2015-10-21 23:02:45 UTC
+++ This bug was initially created as a clone of Bug #1267950 +++

We need a way to pause tiering to take snapshot. A file cannot be in the middle of promotion/demotion when a snapshot is taken. If a file is in the middle of migration, abort the migration and rollback any in-progress work. Implement a CLI for this and to resume migration.

--- Additional comment from Vijay Bellur on 2015-10-13 21:24:12 EDT ---

REVIEW: http://review.gluster.org/12304 (cluster/tier: WIP add pause tier feature (required for snapshots)) posted (#3) for review on master by Dan Lambright (dlambrig)

--- Additional comment from Vijay Bellur on 2015-10-14 23:11:23 EDT ---

REVIEW: http://review.gluster.org/12304 (cluster/tier: add pause tier for snapshots) posted (#4) for review on master by Dan Lambright (dlambrig)

--- Additional comment from Vijay Bellur on 2015-10-16 11:36:14 EDT ---

REVIEW: http://review.gluster.org/12304 (cluster/tier: add pause tier for snapshots) posted (#5) for review on master by Dan Lambright (dlambrig)

--- Additional comment from Vijay Bellur on 2015-10-19 14:24:17 EDT ---

REVIEW: http://review.gluster.org/12304 (cluster/tier: add pause tier for snapshots) posted (#6) for review on master by Dan Lambright (dlambrig)

--- Additional comment from Vijay Bellur on 2015-10-21 10:27:52 EDT ---

REVIEW: http://review.gluster.org/12304 (cluster/tier: add pause tier for snapshots) posted (#7) for review on master by Dan Lambright (dlambrig)

--- Additional comment from Vijay Bellur on 2015-10-21 12:20:15 EDT ---

REVIEW: http://review.gluster.org/12304 (cluster/tier: add pause tier for snapshots) posted (#8) for review on master by Dan Lambright (dlambrig)

--- Additional comment from Vijay Bellur on 2015-10-21 18:44:40 EDT ---

COMMIT: http://review.gluster.org/12304 committed in master by Dan Lambright (dlambrig) 
------
commit 36974c36fa4231df3f0e9428a9da6d1aa33348ab
Author: Dan Lambright <dlambrig>
Date:   Mon Oct 5 19:52:02 2015 +0000

    cluster/tier: add pause tier for snapshots
    
    Snaps of tiered volumes cannot handle files undergoing migration.
    We implement a helper mechanism to "pause" migration. Any files
    undergoing migration are aborted. Clean up is done to remove
    sticky bits and data at the destination. Migration is restarted
    after snap completes.
    
    For testing an internal switch is added. It is not exposed externally.
    
    gluster volume set vol1 tier-pause [true|false]
    
    Change-Id: Ia85bbf89ac142e9b7e73fcbef98bb9da86097799
    BUG: 1267950
    Signed-off-by: Dan Lambright <dlambrig>
    Reviewed-on: http://review.gluster.org/12304
    Reviewed-by: N Balachandran <nbalacha>
    Tested-by: NetBSD Build System <jenkins.org>
    Tested-by: Gluster Build System <jenkins.com>

Comment 1 Vijay Bellur 2015-10-21 23:16:54 UTC
REVIEW: http://review.gluster.org/12411 (cluster/tier: add pause tier for snapshots) posted (#1) for review on release-3.7 by Dan Lambright (dlambrig)

Comment 2 Vijay Bellur 2015-10-22 02:46:23 UTC
COMMIT: http://review.gluster.org/12411 committed in release-3.7 by Dan Lambright (dlambrig) 
------
commit e851ecbb12647f3e66f6d4c1ebdb0741eb3a3d2c
Author: Dan Lambright <dlambrig>
Date:   Mon Oct 5 19:52:02 2015 +0000

    cluster/tier: add pause tier for snapshots
    
    This is a backport of 12304
    
    Snaps of tiered volumes cannot handle files undergoing migration.
    We implement a helper mechanism to "pause" migration. Any files
    undergoing migration are aborted. Clean up is done to remove
    sticky bits and data at the destination. Migration is restarted
    after snap completes.
    
    For testing an internal switch is added. It is not exposed externally.
    
    gluster volume set vol1 tier-pause [true|false]
    
    > Change-Id: Ia85bbf89ac142e9b7e73fcbef98bb9da86097799
    > BUG: 1267950
    > Signed-off-by: Dan Lambright <dlambrig>
    > Reviewed-on: http://review.gluster.org/12304
    > Reviewed-by: N Balachandran <nbalacha>
    > Tested-by: NetBSD Build System <jenkins.org>
    > Tested-by: Gluster Build System <jenkins.com>
    Signed-off-by: Dan Lambright <dlambrig>
    
    Conflicts:
    	xlators/mgmt/glusterd/src/glusterd-messages.h
    
    Change-Id: I5f039d8d38a4c915bd873969f336b96755a0b8f1
    BUG: 1274101
    Reviewed-on: http://review.gluster.org/12411
    Tested-by: NetBSD Build System <jenkins.org>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Dan Lambright <dlambrig>
    Tested-by: Dan Lambright <dlambrig>

Comment 3 Raghavendra Talur 2015-11-17 06:01:01 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.6, please open a new bug report.

glusterfs-3.7.6 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://www.gluster.org/pipermail/gluster-users/2015-November/024359.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.