Bug 1275005 - Review Request: nodejs-tough-cookie - RFC6265 Cookies and Cookie Jar for Node.js
Review Request: nodejs-tough-cookie - RFC6265 Cookies and Cookie Jar for Node.js
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Tom Hughes
Fedora Extras Quality Assurance
Depends On:
Blocks: nodejs-reviews 994934
  Show dependency treegraph
Reported: 2015-10-24 15:36 EDT by Piotr Popieluch
Modified: 2015-11-04 15:52 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2015-11-04 15:52:39 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
tom: fedora‑review+

Attachments (Terms of Use)

  None (edit)
Description Piotr Popieluch 2015-10-24 15:36:39 EDT
Spec URL: https://piotrp.fedorapeople.org/nodejs-tough-cookie.spec
SRPM URL: https://piotrp.fedorapeople.org/nodejs-tough-cookie-2.2.0-1.fc22.src.rpm
Description: RFC6265 Cookies and Cookie Jar for Node.js
Fedora Account System Username: piotrp
Comment 1 Tom Hughes 2015-10-25 13:39:16 EDT
Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "BSD (3 clause)", "*No copyright* MPL (v2.0)", "Unknown or
     generated", "MPL (v2.0) BSD (3 clause)". 9 files have unknown license.
     Detailed output of licensecheck in /home/tom/1275005-nodejs-tough-
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 30720 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

Checking: nodejs-tough-cookie-2.2.0-1.fc24.noarch.rpm
nodejs-tough-cookie.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-tough-cookie.noarch: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-tough-cookie.noarch: W: only-non-binary-in-usr-lib
nodejs-tough-cookie.src: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-tough-cookie.src: W: spelling-error %description -l en_US js -> dis, ks, j
2 packages and 0 specfiles checked; 0 errors, 5 warnings.

Rpmlint (installed packages)
sh: /usr/bin/python: No such file or directory
nodejs-tough-cookie.noarch: W: only-non-binary-in-usr-lib
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

nodejs-tough-cookie (rpmlib, GLIBC filtered):


Source checksums
https://github.com/SalesforceEng/tough-cookie/archive/fb1456177c9b51445afa34656eb314c70c2adcd2.tar.gz#/tough-cookie-fb14561.tar.gz :
  CHECKSUM(SHA256) this package     : 55970b1b9a94d5c7a3ca45f4fedef87e47be1a978390d490ba925144f61ffbf1
  CHECKSUM(SHA256) upstream package : 55970b1b9a94d5c7a3ca45f4fedef87e47be1a978390d490ba925144f61ffbf1

Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -m compton-rawhide-x86_64 -b 1275005
Buildroot used: compton-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Comment 2 Tom Hughes 2015-10-25 13:42:41 EDT
The test failure is because our vows is too old. If you use 0.8.1 then it passes.

My only concern here is licensing the lib/pubsuffix.js code is generated from the public_suffix_list.dat file, which is under MPL 2.0 so the license tag on the RPM should reflect that.
Comment 3 Piotr Popieluch 2015-10-25 14:55:56 EDT
Thanks, updated package, same urls.
Comment 4 Tom Hughes 2015-10-25 15:21:14 EDT
Great. Package approved then.

I've got an updated vows building in rawhide now (http://koji.fedoraproject.org/koji/taskinfo?taskID=11577813) so once that is done you should be able to enable the tests as well.
Comment 5 Piotr Popieluch 2015-10-25 15:43:18 EDT
Nice, will enable tests. Thank you!
Comment 6 Fedora Update System 2015-10-26 16:47:04 EDT
nodejs-tough-cookie-2.2.0-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-0ab123b9c9
Comment 7 Fedora Update System 2015-10-26 22:17:40 EDT
nodejs-tough-cookie-2.2.0-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update nodejs-tough-cookie'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-0ab123b9c9
Comment 8 Fedora Update System 2015-11-04 15:52:37 EST
nodejs-tough-cookie-2.2.0-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.