Bug 1275438 - Review Request: xindy - Index generator for structured documents like LaTeX or SGML
Review Request: xindy - Index generator for structured documents like LaTeX o...
Status: NEW
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
unspecified Severity medium
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Extras Quality Assurance
:
Depends On:
Blocks: FE-DEADREVIEW
  Show dependency treegraph
 
Reported: 2015-10-26 18:23 EDT by Attila Zsolt Sajo
Modified: 2017-03-05 17:35 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed:
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
zbyszek: fedora‑review?


Attachments (Terms of Use)

  None (edit)
Description Attila Zsolt Sajo 2015-10-26 18:23:41 EDT
Spec URL: http://landscape.geo.klte.hu/sajozsattila/Fedora_packages/xindy.spec
SRPM URL: http://landscape.geo.klte.hu/sajozsattila/Fedora_packages/xindy-2.5.1-1.fc21.src.rpm

Description: xindy is an index processor that can be used to generate book-like
indexes for arbitrary document-preparation systems. This includes
systems such as TeX and LaTeX, the roff-family, SGML/XML-based
systems (e.g. HTML) that process some kind of text and generate
indexing information. The kernel system is not fixed to any specific
system, but can be configured to work together with such systems.

In comparison to other index processors xindy has several powerful
features that make it an ideal framework for describing and
generating complex indices, addressing especially international
indexing.

Fedora Account System Username: sajozsattila
Comment 1 Attila Zsolt Sajo 2015-10-26 18:29:12 EDT
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=11589399

%%%%%%%%%%%%%
i686 and x86_64 is build without error

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
Output of rpmlint -i xindy.spec xindy-2.5.1-1.fc21.i686.rpm xindy-2.5.1-1.fc21.src.rpm:

xindy.i686: W: spelling-error %description -l en_US roff -> toff, riff, off
The value of this tag appears to be misspelled. Please double-check.

xindy.i686: W: only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.

xindy.src: W: spelling-error %description -l en_US roff -> toff, riff, off
The value of this tag appears to be misspelled. Please double-check.

2 packages and 1 specfiles checked; 0 errors, 3 warnings.

%%%%%%%%%%%%%%
There is no speeling-error in the description, see above.

I doo not know what I suppose to do with the only-non-binary-in-usr-lib warning.
Comment 2 Christopher Meng 2015-10-27 04:44:00 EDT
Your spec doesn't match the Fedora standard:

0. Please use full brackets:

%{buildroot}, not %buildroot, also, 
1. make -j1

Reason?

2. clisp sucks on ARM.

3. 
make install DESTDIR="%buildroot";
rm -f "%buildroot/%_prefix/VERSION";

";" means nothing here, not sure why you added it.

4. %clean is not needed, and Group as well.

5. You don't need to put your long name or email address on the top to show it's something from you, we all know it's a "spec file for package xindy" from its Name. Your email will be showned at %changelog section.

6. Invalid changelog, please read guideline to see how to write good changelog.
Comment 3 Upstream Release Monitoring 2015-10-27 06:39:07 EDT
sajozsattila's scratch build of xindy-2.5.1-1.fc21.src.rpm for f22 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11597186
Comment 4 Attila Zsolt Sajo 2015-10-27 07:03:40 EDT
I have corrected the mistakes except the ARM build error.  It is a SIGSEGV error (see: https://kojipkgs.fedoraproject.org//work/tasks/7191/11597191/build.log), which need more effort to solve. I haven't got hardware to properly debug, so I do not see when I can solve this.

Check the updated spec file (same address), and the the new Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=11597186
Comment 5 Zbigniew Jędrzejewski-Szmek 2016-01-20 17:01:53 EST
Package looks good, apart from some trivial possible improvements:

- BuildRoot is not necessary in Fedora.
- %defattr also not necessary.
- make install DESTDIR="%{buildroot}" → %make_install

I'd be happy to sponsor you into the packagers group. Please do two or three reviews of packages from http://fedoraproject.org/PackageReviewStatus/NEW.html and paste the links here. If you have any questions or issues, I'll try to help (zbyszek at in waw pl, zbyszek on #fedora-devel).

Standard disclaimer: Running fedora-review is a good first step, but please note that the automatically generated template needs to be filled in in various places, and trimmed in others. Not everything the tools say is always correct. Sometimes they are outdated, sometimes they are plain wrong. It's always best to link to the relevant part of the guidelines. Please pick packages that are in the area you are interested in, so that you can finalize the review after you get the packager bit.
Comment 6 Upstream Release Monitoring 2016-01-20 17:10:10 EST
zbyszek's scratch build of xindy-2.5.1-1.fc21.src.rpm for f23 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12624931
Comment 7 Upstream Release Monitoring 2016-01-20 17:19:57 EST
zbyszek's scratch build of xindy-2.5.1-1.fc21.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12624932
Comment 8 Zbigniew Jędrzejewski-Szmek 2016-01-20 17:34:48 EST
Just open a bug for clisp. For now you can add ExcludeArch.
Comment 9 Zbigniew Jędrzejewski-Szmek 2016-03-01 16:22:17 EST
?

Note You need to log in before you can comment on or make changes to this bug.