Bug 1276108 - Review Request: nodejs-generate-function - Module that helps you write generated functions in Node
Summary: Review Request: nodejs-generate-function - Module that helps you write genera...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Tom Hughes
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: nodejs-reviews
TreeView+ depends on / blocked
 
Reported: 2015-10-28 18:04 UTC by Piotr Popieluch
Modified: 2015-11-10 00:22 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-11-08 22:22:06 UTC
Type: ---
Embargoed:
tom: fedora-review+


Attachments (Terms of Use)

Description Piotr Popieluch 2015-10-28 18:04:01 UTC
Spec URL: https://piotrp.fedorapeople.org/nodejs-generate-function.spec
SRPM URL: https://piotrp.fedorapeople.org/nodejs-generate-function-2.0.0-1.fc22.src.rpm
Description: Module that helps you write generated functions in Node
Fedora Account System Username: piotrp

Comment 1 Tom Hughes 2015-10-28 21:20:13 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "MIT/X11 (BSD like)", "Unknown or generated". 6 files have
     unknown license. Detailed output of licensecheck in /home/tom/1276108
     -nodejs-generate-function/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: nodejs-generate-function-2.0.0-1.fc24.noarch.rpm
          nodejs-generate-function-2.0.0-1.fc24.src.rpm
nodejs-generate-function.noarch: W: only-non-binary-in-usr-lib
2 packages and 0 specfiles checked; 0 errors, 1 warnings.




Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
nodejs-generate-function.noarch: W: only-non-binary-in-usr-lib
1 packages and 0 specfiles checked; 0 errors, 1 warnings.



Requires
--------
nodejs-generate-function (rpmlib, GLIBC filtered):
    nodejs(engine)



Provides
--------
nodejs-generate-function:
    nodejs-generate-function
    npm(generate-function)



Source checksums
----------------
https://github.com/mafintosh/generate-function/archive/af11020b5280972156c46876d9779c0e448fdfcb.tar.gz#/generate-function-af11020.tar.gz :
  CHECKSUM(SHA256) this package     : f07e80f542fab49ac4d396af684c64c3bbfe787447c59e6542b007cfea162e5b
  CHECKSUM(SHA256) upstream package : f07e80f542fab49ac4d396af684c64c3bbfe787447c59e6542b007cfea162e5b


Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -m compton-rawhide-x86_64 -b 1276108
Buildroot used: compton-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 2 Tom Hughes 2015-10-28 21:23:06 UTC
So this is versioned as 2.0.0-1 but it the source is from github using a commit hash that does not correspond to the 2.0.0 release.

As I see it there are a few valid options at this point:

* Assuming it's just the license missing, ship from npmjs with license pulled in separately for now (either as another source or by patch)

* Ship correct 2.0.0 tar ball from github with license added separately as above

* Ship versioned as a 2.0.0 post release snapshot as per the versioning rules.

Comment 3 Piotr Popieluch 2015-10-29 12:58:25 UTC
Yes, I took release+one commit to have the license included.

I've updated for option 2.

Comment 4 Tom Hughes 2015-10-29 19:15:41 UTC
Looks good now. Package approved.

Comment 5 Piotr Popieluch 2015-10-29 19:26:10 UTC
Thanks

Comment 6 Fedora Update System 2015-10-30 08:13:00 UTC
nodejs-generate-function-2.0.0-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-910b46b511

Comment 7 Fedora Update System 2015-10-30 08:13:37 UTC
nodejs-generate-function-2.0.0-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-25e6cdf77a

Comment 8 Fedora Update System 2015-11-01 06:57:02 UTC
nodejs-generate-function-2.0.0-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update nodejs-generate-function'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-910b46b511

Comment 9 Fedora Update System 2015-11-02 00:25:44 UTC
nodejs-generate-function-2.0.0-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update nodejs-generate-function'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-25e6cdf77a

Comment 10 Fedora Update System 2015-11-08 22:21:53 UTC
nodejs-generate-function-2.0.0-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2015-11-10 00:22:44 UTC
nodejs-generate-function-2.0.0-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.