Red Hat Bugzilla – Bug 1276216
Pod terminal page didn't adjust automatically to fit its size with browser window
Last modified: 2017-06-22 03:11:57 EDT
Description of problem:
When browser window width is less than 702, the re-connect button on 'Terminal' page of pod was pushed to the lower left corner.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1.Create a template
$ oc create -f https://raw.githubusercontent.com/openshift/origin/master/examples/sample-app/application-template-stibuild.json
2. Create app from template from web console
3. Wait for all pods to be running
4. Open 'Terminal' page for one pod
5. Resize the browser window
When browser window width is less than 702, the re-connect button on 'Terminal' page of pod was pushed to the lower left corner, see attachment
re-connect button should always shows at the right position
702 is not a precise value, but it's very close to the correct one
Created attachment 1087384 [details]
Button in lower left corner
Because the terminal-actions and terminal-wrapper divs are both inline-block, when you get to a certain screen resolution the second div (actions) drops to the next line, and then the relative positioning pushes it to the left, cutting it off. I would propose moving the terminal-actions to the bottom left instead of the top right, we can then use position: absolute instead of position relative and it will always stay in the same position.
But since this is a change to a common widget I'd like sign-off from @stefw before moving forward with the fix.
This was fixed back in 3.3
Checked on v1.4.0-alpha.1+43fbf69-133 & OCP 22.214.171.124
Pod Terminal are not fully shown on iPhone 6, please check attachment
Created attachment 1219191 [details]
//div[@class="terminal"] are not fully displayed when browser width changes to smaller
The terminal extending out is intentional, we require a minimum number of columns (80), you should be able to scroll over using the swipe gesture to see the rest of the terminal.
The location of the reconnect icon at this screen width is a little weird though, we'll take another look at that.
Steve can you take a look at the position of the reconnect icon at mobile.
Created attachment 1290191 [details]
Position of reconnect icon corrected
Was addressed in https://github.com/openshift/origin-web-console/commit/99e338cf2616fe992adfc9c02d123d01eee15c7a
origin bug, so moving to ON_QA
Checked this issue in openshift v3.6.122, it was fixed, change this bug status to verified.