Bug 1276350 - User task comments sorting
User task comments sorting
Product: JBoss BPMS Platform 6
Classification: JBoss
Component: jBPM Core (Show other bugs)
Unspecified Unspecified
medium Severity low
: CR1
: 6.2.0
Assigned To: Maciej Swiderski
Jakub Schwan
Depends On:
  Show dependency treegraph
Reported: 2015-10-29 10:09 EDT by Karel Suta
Modified: 2015-11-27 10:02 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed:
Type: Enhancement
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Karel Suta 2015-10-29 10:09:30 EDT
Description of problem:
Retrieving of user task comments (method getCommentsByTaskId(Long taskId) in UserTaskServiceImpl) return list of comments without defined sorting. For lot of databases it isn't an issue as they return comments ordered by id, but for example Oracle database return comments with random ordering.

It would be nice to have consist ordering of comments for all databases all the time.

Version-Release number of selected component (if applicable):

How reproducible:
Simulated on kie server - test testUserTaskComments() in UserTaskServiceIntegrationTest. If kie server is backed by Oracle database then taskClient.getTaskCommentsByTaskId returns comments in random order - tests count with it so they will pass all the time.

Steps to Reproduce:

Actual results:
Comments are returned in random order.

Expected results:
Comments has consistent order all the time for all databases.

Additional info:
Comment 2 Karel Suta 2015-10-29 10:17:00 EDT
Created PR with fix proposal: https://github.com/droolsjbpm/jbpm/pull/322
Comment 4 Jakub Schwan 2015-11-27 10:02:36 EST
Verified in 6.2.0 CR1

Note You need to log in before you can comment on or make changes to this bug.