RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1276685 - memory leak in svc_vc_create
Summary: memory leak in svc_vc_create
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libtirpc
Version: 7.3
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Steve Dickson
QA Contact: Murphy Zhou
URL:
Whiteboard:
Depends On:
Blocks: 1276687
TreeView+ depends on / blocked
 
Reported: 2015-10-30 13:47 UTC by Steve Dickson
Modified: 2017-11-20 06:18 UTC (History)
3 users (show)

Fixed In Version: libtirpc-0.2.4-0.7.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1276687 (view as bug list)
Environment:
Last Closed: 2016-11-04 02:15:17 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:2280 0 normal SHIPPED_LIVE libtirpc bug fix update 2016-11-03 13:35:59 UTC

Description Steve Dickson 2015-10-30 13:47:44 UTC
Description of problem:
Here is the needed patch

Fix memory leak on failure in svc_vc_create

Do not leak memory (the r variable) when __rpc_fd2sockinfo fails.

Signed-off-by: Peter Rosin <peda.se>
---
 src/svc_vc.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/svc_vc.c b/src/svc_vc.c
index 4bafbcf..ea80313 100644
--- a/src/svc_vc.c
+++ b/src/svc_vc.c
@@ -157,8 +157,10 @@ svc_vc_create(fd, sendsize, recvsize)
 		warnx("svc_vc_create: out of memory");
 		goto cleanup_svc_vc_create;
 	}
-	if (!__rpc_fd2sockinfo(fd, &si))
-		return NULL;
+	if (!__rpc_fd2sockinfo(fd, &si)) {
+		warnx("svc_vc_create: __rpc_fd2sockinfo failed");
+		goto cleanup_svc_vc_create;
+	}
 	r->sendsize = __rpc_get_t_size(si.si_af, si.si_proto, (int)sendsize);
 	r->recvsize = __rpc_get_t_size(si.si_af, si.si_proto, (int)recvsize);
 	r->maxrec = __svc_maxrec;

Comment 5 errata-xmlrpc 2016-11-04 02:15:17 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-2280.html


Note You need to log in before you can comment on or make changes to this bug.