Bug 1277618
| Summary: | Atomic run echo's docker command twice | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Chris Evich <cevich> |
| Component: | atomic | Assignee: | Lokesh Mandvekar <lsm5> |
| Status: | CLOSED ERRATA | QA Contact: | atomic-bugs <atomic-bugs> |
| Severity: | low | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 7.1 | CC: | ajia, dwalsh, lsm5, miabbott |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-03-31 23:25:17 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Chris Evich
2015-11-03 16:33:16 UTC
Fixed in atomic-1.5-2.git191fb53.el7 Added task for CI tests in https://trello.com/c/BlIJ0DP0 Atomic run works well on atomic-1.8-6.git1bc3814.el7.x86_64, so move the bug VERIFIED status.
# atomic run rhel7/rsyslog
docker run -d --privileged --name rsyslog --net=host --pid=host -v /etc/pki/rsyslog:/etc/pki/rsyslog -v /etc/rsyslog.conf:/etc/rsyslog.conf -v /etc/sysconfig/rsyslog:/etc/sysconfig/rsyslog -v /etc/rsyslog.d:/etc/rsyslog.d -v /var/log:/var/log -v /var/lib/rsyslog:/var/lib/rsyslog -v /run:/run -v /etc/machine-id:/etc/machine-id -v /etc/localtime:/etc/localtime -e IMAGE=rhel7/rsyslog -e NAME=rsyslog --restart=always rhel7/rsyslog /bin/rsyslog.sh
This container uses privileged security switches:
INFO: --net=host
Processes in this container can listen to ports (and possibly rawip traffic) on the host's network.
INFO: --pid=host
Processes in this container can see and interact with all processes on the host and disables SELinux within the container.
INFO: --privileged
This container runs without separation and should be considered the same as root on your system.
For more information on these switches and their security implications, consult the manpage for 'docker run'.
c5eb2d69dbfef3168985e15b35300635d7dc503e4b7cbf7e6b4a15d456a3a039
Usage of loopback devices is strongly discouraged for production use. Either use `--storage-opt dm.thinpooldev` or use `--storage-opt dm.no_warn_on_loop_devices=true` to suppress this warning.
# docker ps
CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES
c5eb2d69dbfe rhel7/rsyslog "/bin/rsyslog.sh" 14 seconds ago Up 12 seconds rsyslog
(In reply to Daniel Walsh from comment #2) > Fixed in atomic-1.5-2.git191fb53.el7 This fails verify for me on atomic-1.6-6.gitca1e384.el7.x86_64 (7.2.1) but passes in 1.8. However, now there is _no_ command echo. If this is a design-decision/change, that's fine. I just want to double-check: 1) What version of atomic did this really change in (1.7)? 2) Is not echo'ing any docker command intended or an error? Latest behaviour: -bash-4.2# atomic host status TIMESTAMP (UTC) VERSION ID OSNAME REFSPEC * 2016-02-01 01:13:15 7.2.internal.0.608 919337b3bf rhel-atomic-host rhel-atomic-host-ostree:rhel-atomic-host/7.2/x86_64/continuous/buildmaster 2015-12-03 19:40:36 7.2.1 aaf67b91fa rhel-atomic-host rhel-atomic-host-ostree:rhel-atomic-host/7/x86_64/standard -bash-4.2# rpm -q atomic atomic-1.8.41-c893521978a2670ae1579b4e6eea8ccfa0c5e9f2.fcf70d203a56e7ca57e407cc0cea2abe008136dc.el7.x86_64 -bash-4.2# atomic --version 1.8 -bash-4.2# atomic run registry.access.redhat.com/rhel7/rhel-tools:latest [root@rhelah72-2pjkve /]# Previous behavior (7.2.1): -bash-4.2# docker images REPOSITORY TAG IMAGE ID CREATED VIRTUAL SIZE registry.access.redhat.com/rhel7/rhel-tools latest fd2acbeb2b97 8 weeks ago 1.159 GB -bash-4.2# atomic --version 1.6 -bash-4.2# rpm -q atomic atomic-1.6-6.gitca1e384.el7.x86_64 -bash-4.2# atomic run registry.access.redhat.com/rhel7/rhel-tools:latest docker run -it --name rhel-tools --privileged --ipc=host --net=host --pid=host -e HOST=/host -e NAME=rhel-tools -e IMAGE=registry.access.redhat.com/rhel7/rhel-tools:latest -v /run:/run -v /var/log:/var/log -v /etc/localtime:/etc/localtime -v /:/host registry.access.redhat.com/rhel7/rhel-tools:latest docker run -it --name rhel-tools --privileged --ipc=host --net=host --pid=host -e HOST=/host -e NAME=rhel-tools -e IMAGE=registry.access.redhat.com/rhel7/rhel-tools:latest -v /run:/run -v /var/log:/var/log -v /etc/localtime:/etc/localtime -v /:/host registry.access.redhat.com/rhel7/rhel-tools:latest [root@rhelah72-2pjkve /]# exit -bash-4.2# atomic host status TIMESTAMP (UTC) VERSION ID OSNAME REFSPEC * 2015-12-03 19:40:36 7.2.1 aaf67b91fa rhel-atomic-host rhel-atomic-host-ostree:rhel-atomic-host/7/x86_64/standard 2015-11-10 16:11:46 7.2 ec85fba1bf rhel-atomic-host rhel-atomic-host-ostree:rhel-atomic-host/7/x86_64/standard -bash-4.2# Note: More playing with RHEL Atomic + upstream bits rebuilt on top. This package seems to do 'the right thing':
# rpm -q atomic
atomic-1.8.41-c893521978a2670ae1579b4e6eea8ccfa0c5e9f2.fcf70d203a56e7ca57e407cc0cea2abe008136dc.el7.x86_64
# atomic --version
1.8
# atomic run rhel7/rhel-tools
Using default tag: latest
fd2acbeb2b97: Download complete
6c3a84d798dc: Download complete
Status: Image is up to date for docker.io/rhel7/rhel-tools:latest
docker.io/rhel7/rhel-tools: this image was pulled from a legacy registry. Important: This registry version will not be supported in future versions of docker.
docker run -it --name rhel-tools --privileged --ipc=host --net=host --pid=host -e HOST=/host -e NAME=rhel-tools -e IMAGE=rhel7/rhel-tools -v /run:/run -v /var/log:/var/log -v /etc/localtime:/etc/localtime -v /:/host rhel7/rhel-tools
This container uses privileged security switches:
INFO: --ipc=host
Processes in this container can see and possibly interact with all semaphores and shared memory segments on the host as well as disables SELinux within the container.
INFO: --net=host
Processes in this container can listen to ports (and possibly rawip traffic) on the host's network.
INFO: --pid=host
Processes in this container can see and interact with all processes on the host and disables SELinux within the container.
INFO: --privileged
This container runs without separation and should be considered the same as root on your system.
For more information on these switches and their security implications, consult the manpage for 'docker run'.
So I've 'fudged' my test's version check for atomic > 1.7 should only echo command once. It would still be helpful to confirm this is the right version and to confirm most recent builds actually still echo the command once or not.
(In reply to Chris Evich from comment #7) > (In reply to Daniel Walsh from comment #2) > > Fixed in atomic-1.5-2.git191fb53.el7 > > This fails verify for me on atomic-1.6-6.gitca1e384.el7.x86_64 (7.2.1) but > passes in 1.8. However, now there is _no_ command echo. If this is a > design-decision/change, that's fine. I just want to double-check: > > 1) What version of atomic did this really change in (1.7)? > 2) Is not echo'ing any docker command intended or an error? Dan, I guess you're the right person to comment on ^ > > Latest behaviour: > > -bash-4.2# atomic host status > TIMESTAMP (UTC) VERSION ID OSNAME > REFSPEC > > * 2016-02-01 01:13:15 7.2.internal.0.608 919337b3bf > rhel-atomic-host > rhel-atomic-host-ostree:rhel-atomic-host/7.2/x86_64/continuous/buildmaster > > 2015-12-03 19:40:36 7.2.1 aaf67b91fa > rhel-atomic-host > rhel-atomic-host-ostree:rhel-atomic-host/7/x86_64/standard > > -bash-4.2# rpm -q atomic > atomic-1.8.41-c893521978a2670ae1579b4e6eea8ccfa0c5e9f2. > fcf70d203a56e7ca57e407cc0cea2abe008136dc.el7.x86_64 > -bash-4.2# atomic --version > 1.8 > -bash-4.2# atomic run registry.access.redhat.com/rhel7/rhel-tools:latest > [root@rhelah72-2pjkve /]# > > > Previous behavior (7.2.1): > > -bash-4.2# docker images > REPOSITORY TAG IMAGE ID > CREATED VIRTUAL SIZE > registry.access.redhat.com/rhel7/rhel-tools latest > fd2acbeb2b97 8 weeks ago 1.159 GB > -bash-4.2# atomic --version > 1.6 > -bash-4.2# rpm -q atomic > atomic-1.6-6.gitca1e384.el7.x86_64 > -bash-4.2# atomic run registry.access.redhat.com/rhel7/rhel-tools:latest > docker run -it --name rhel-tools --privileged --ipc=host --net=host > --pid=host -e HOST=/host -e NAME=rhel-tools -e > IMAGE=registry.access.redhat.com/rhel7/rhel-tools:latest -v /run:/run -v > /var/log:/var/log -v /etc/localtime:/etc/localtime -v /:/host > registry.access.redhat.com/rhel7/rhel-tools:latest > docker run -it --name rhel-tools --privileged --ipc=host --net=host > --pid=host -e HOST=/host -e NAME=rhel-tools -e > IMAGE=registry.access.redhat.com/rhel7/rhel-tools:latest -v /run:/run -v > /var/log:/var/log -v /etc/localtime:/etc/localtime -v /:/host > registry.access.redhat.com/rhel7/rhel-tools:latest > > [root@rhelah72-2pjkve /]# exit > > -bash-4.2# atomic host status > TIMESTAMP (UTC) VERSION ID OSNAME > REFSPEC > * 2015-12-03 19:40:36 7.2.1 aaf67b91fa rhel-atomic-host > rhel-atomic-host-ostree:rhel-atomic-host/7/x86_64/standard > 2015-11-10 16:11:46 7.2 ec85fba1bf rhel-atomic-host > rhel-atomic-host-ostree:rhel-atomic-host/7/x86_64/standard > -bash-4.2# Atomic command is supposed to echo it once. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2016-0527.html |