From Bugzilla Helper: User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040510 Description of problem: Hi, I've just upgraded to Fedora Core 2, and the autofs has changed from 3.1.7 to 4.1.2. Previously, I would automount Windows shares using an auto.smb file with an entry: myshare -fstype=smbfs,username=mydomain\\myuserid,password=insecure,uid=500,gid=500,fmask=775 ://winsvr/myshare In the new autofs 4.1.2 package, the above entry provokes a bug which was not present before. Windows requires the username to be of the form: mydomain\myuserid The problem is that the new autofs strips ALL backslashes from the options, and supplies mount.smb with: username=mydomainmyuserid The attached patch fixes this, but I would suggest someone more familiar with the package review it, since I have not analysed the source to any great depth. Regards, George Hansper Version-Release number of selected component (if applicable): autofs-4.1.2-2 How reproducible: Always Steps to Reproduce: 1. Create a share on a Windows domain 2. Add /etc/auto.smb to /etc/auto.master: /smb /etc/auto.smb --timeout=3600 -d 3. Add an entry for the windows share to /etc/auto.smb myshare -fstype=smbfs,username=mydomain\\myuserid,password=insecure,uid=500,gid=500,fmask=775 ://winsvr/myshare 4. Try to access /smb/myshare: ls /smb/myshare Actual Results: ls: /smb/myshare: No such file or directory and in /var/log/messages: Jul 14 12:12:34 georgeh automount[23932]: attempting to mount entry /smb/myshare Jul 14 12:12:34 georgeh automount[26603]: >> 26608: session setup failed: ERRDOS - ERRnoaccess (Access denied.) Jul 14 12:12:34 georgeh automount[26603]: >> SMB connection failed Jul 14 12:12:34 georgeh automount[26603]: mount(generic): failed to mount //winsvr/myshare (type smbfs) on /smb/myshare Jul 14 12:12:34 georgeh automount[26603]: failed to mount /smb/myshare Expected Results: Listing of directory (Widows share) Additional info: Mounting from the command line works. Also posted to <autofs.org> Patch: --- autofs-4.1.2/modules/parse_sun.c.orig 2004-02-04 02:23:21.000000000 +1100 +++ autofs-4.1.2/modules/parse_sun.c 2004-07-14 12:15:30.311818691 +1000 @@ -261,9 +261,12 @@ for (; *whence; whence++, n++) { switch (*whence) { case '\\': - quote = 1; - continue; - + if( quote ) { + break; + } else { + quote = 1; + continue; + } case ':': if (expect_colon) expect_colon = 0; @@ -451,13 +454,17 @@ char *cp = ret; const char *scp; int origlen = strlen; + int quote = 0; if (ret == NULL) return NULL; for (scp = str; strlen > 0 && *scp; scp++, strlen--) { - if (*scp == '\\') + if (*scp == '\\' && !quote ) { + quote = 1; continue; + } + quote = 0; *cp++ = *scp; } *cp = '\0';
Created attachment 101885 [details] autofs patch allowing backslashes to be quoted and included in options
Fedora Core 2 is now maintained by the Fedora Legacy project for security updates only. If this problem is a security issue, please reopen and reassign to the Fedora Legacy product. If it is not a security issue and hasn't been resolved in the current FC3 updates or in the FC4 test release, reopen and change the version to match.
Ian, is this still an issue?
(In reply to comment #3) > Ian, is this still an issue? I don't think so. I'd recommend using the FC3 4.1.3 or going to the FC4 4.1.4. It's likely that it would need to be built from a SRPM to satisfy libray dependencies of course.
Since FC2 is Fedora Legacy now, and this is not a security issue, it's not going to be fixed in FC2. Recommend upgrading to FC3 or FC4, or applying the patch yourself if necessary. Closing bug.