Bug 1278487 - Review Request: nodejs-path-to-regexp - Express style path to RegExp utility
Summary: Review Request: nodejs-path-to-regexp - Express style path to RegExp utility
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Tom Hughes
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: nodejs-reviews Node-RED
TreeView+ depends on / blocked
 
Reported: 2015-11-05 15:26 UTC by Jared Smith
Modified: 2016-10-21 08:13 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-07-08 15:04:17 UTC
Type: ---
Embargoed:
tom: fedora-review+


Attachments (Terms of Use)

Description Jared Smith 2015-11-05 15:26:06 UTC
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-path-to-regexp/nodejs-path-to-regexp.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-path-to-regexp/nodejs-path-to-regexp-1.2.1-1.fc24.src.rpm
Description: Express style path to RegExp utility
Fedora Account System Username: jsmith

Comment 2 Tom Hughes 2015-11-07 11:12:05 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "MIT/X11 (BSD like)", "Unknown or generated". 5 files have
     unknown license. Detailed output of licensecheck in /home/tom/1278487
     -nodejs-path-to-regexp/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: nodejs-path-to-regexp-1.2.1-2.fc24.noarch.rpm
          nodejs-path-to-regexp-1.2.1-2.fc24.src.rpm
nodejs-path-to-regexp.noarch: W: only-non-binary-in-usr-lib
nodejs-path-to-regexp.noarch: W: dangling-symlink /usr/lib/node_modules/path-to-regexp/node_modules/isarray /usr/lib/node_modules/isarray
2 packages and 0 specfiles checked; 0 errors, 2 warnings.




Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
nodejs-path-to-regexp.noarch: W: only-non-binary-in-usr-lib
nodejs-path-to-regexp.noarch: W: dangling-symlink /usr/lib/node_modules/path-to-regexp/node_modules/isarray /usr/lib/node_modules/isarray
1 packages and 0 specfiles checked; 0 errors, 2 warnings.



Requires
--------
nodejs-path-to-regexp (rpmlib, GLIBC filtered):
    nodejs
    nodejs(engine)
    npm(isarray)



Provides
--------
nodejs-path-to-regexp:
    nodejs-path-to-regexp
    npm(path-to-regexp)



Source checksums
----------------
https://registry.npmjs.org/path-to-regexp/-/path-to-regexp-1.2.1.tgz :
  CHECKSUM(SHA256) this package     : 770f109302afca15e8ff3c9809e22c7c18925f2d8923898b4885ba2c8d1757cd
  CHECKSUM(SHA256) upstream package : 770f109302afca15e8ff3c9809e22c7c18925f2d8923898b4885ba2c8d1757cd
https://raw.githubusercontent.com/pillarjs/path-to-regexp/7a3361bf5d38098e0cb3c072878bc5535aeab739/test.js :
  CHECKSUM(SHA256) this package     : b209a37b1055370a445716f994cf04d33568660dfc5486254d28600ab9d02557
  CHECKSUM(SHA256) upstream package : b209a37b1055370a445716f994cf04d33568660dfc5486254d28600ab9d02557


Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -m compton-rawhide-x86_64 -b 1278487
Buildroot used: compton-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 3 Tom Hughes 2015-11-07 11:12:49 UTC
I think the only issue here is that test.js is being included in the build package.

Comment 4 Tom Hughes 2015-11-07 11:16:11 UTC
Also I think it would be better to get the tests from:

  https://raw.githubusercontent.com/pillarjs/path-to-regexp/v%{version}/test.js

rather than using a specific hash, so that it's more likely they will get updated when the version changes.

Comment 6 Jared Smith 2015-11-09 17:19:48 UTC
Oops, updated the wrong bug with the previous comment because I was rushing.

Updated this one as well.

Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-path-to-regexp/nodejs-path-to-regexp.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-path-to-regexp/nodejs-path-to-regexp-1.2.1-3.fc24.src.rpm

Comment 7 Tom Hughes 2015-11-09 17:31:59 UTC
Looks good now. Package approved.

Comment 8 Gwyn Ciesla 2016-07-05 16:20:06 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/nodejs-path-to-regexp


Note You need to log in before you can comment on or make changes to this bug.