Bug 1278689 - quota/marker: quota accouting goes wrong with renaming file when IO in progress
Summary: quota/marker: quota accouting goes wrong with renaming file when IO in progress
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: quota
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Manikandan
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-11-06 07:44 UTC by Vijaikumar Mallikarjuna
Modified: 2016-06-16 13:43 UTC (History)
3 users (show)

Fixed In Version: glusterfs-3.8rc2
Clone Of:
Environment:
Last Closed: 2016-06-16 13:43:12 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Vijaikumar Mallikarjuna 2015-11-06 07:44:52 UTC
Testcase './tests/bugs/quota/bug-1235182.t' fails spuriously.


for in in {1..200}; do prove -vf ./tests/bugs/quota/bug-1235182.t; if [ $? -ne 0 ]; then read x; fi; done
....
ok 156
ok 157
ok 158
ok 159
ok 160
ok 161
ok 162
Wait for process with pid 31499 to complete
Process with pid 31499 finished
ok 163
not ok 164 Got "129.8MB" instead of "100.0MB"
FAILED COMMAND: 100.0MB quotausage /
                  Path                   Hard-limit  Soft-limit      Used  Available  Soft-limit exceeded? Hard-limit exceeded?
-------------------------------------------------------------------------------------------------------------------------------
/    



Below is the xattrs in the backend
root@rh1:~/workspace/git/glusterfs # ll /d/backends/patchy/8/
total 0
root@rh1:~/workspace/git/glusterfs # getfattr /d/backends/patchy/8/
getfattr: Removing leading '/' from absolute path names
# file: d/backends/patchy/8/
security.selinux=0x756e636f6e66696e65645f753a6f626a6563745f723a64656661756c745f743a733000
trusted.gfid=0x414248e7312a4ac5a13631ceaa99f171
trusted.glusterfs.dht=0x000000010000000000000000ffffffff
trusted.glusterfs.quota.00000000-0000-0000-0000-000000000001.contri.1=0x0000000001dc100000000000000000010000000000000001
trusted.glusterfs.quota.dirty=0x3000
trusted.glusterfs.quota.size.1=0x0000000001dc100000000000000000010000000000000001

root@rh1:~/workspace/git/glusterfs # ll /d/backends/patchy/51/f51
-rw-------. 2 root root 104857600 Nov  6 12:37 /d/backends/patchy/51/f51
root@rh1:~/workspace/git/glusterfs # getfattr /d/backends/patchy/51/f51
getfattr: Removing leading '/' from absolute path names
# file: d/backends/patchy/51/f51
security.selinux=0x756e636f6e66696e65645f753a6f626a6563745f723a64656661756c745f743a733000
trusted.bit-rot.version=0x0200000000000000563c51a6000aea10
trusted.gfid=0x3df73a6c8cb942e98facf3c528fe5fb1
trusted.glusterfs.quota.28526e69-a923-4df9-9cbe-69ffd0bcc5a0.contri.1=0x00000000064010000000000000000001
trusted.glusterfs.quota.414248e7-312a-4ac5-a136-31ceaa99f171.contri.1=0x0000000001dc10000000000000000001
trusted.pgfid.28526e69-a923-4df9-9cbe-69ffd0bcc5a0=0x00000001





----------------------
After when file is moved out from /8/f1, quota size in parent /8 has not been reduced. I suspect somehow 'mq_reduce_parent_size_txn' has aborted without updating the parent size

Comment 1 Vijaikumar Mallikarjuna 2015-11-06 07:50:42 UTC
patch# 12526, marking testcase './tests/bugs/quota/bug-1235182.t', once this bug this fixed. remove the testcase from bad list

Comment 2 Vijaikumar Mallikarjuna 2015-11-07 06:53:37 UTC
Actual bug is not yet fixed, so reopening bug

Comment 3 Vijay Bellur 2015-11-16 07:24:36 UTC
REVIEW: http://review.gluster.org/12546 (quota: fix spurious failure) posted (#3) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 4 Vijay Bellur 2015-11-16 07:27:13 UTC
REVIEW: http://review.gluster.org/12546 (quota: fix spurious failure) posted (#4) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 5 Vijay Bellur 2015-11-17 10:08:54 UTC
COMMIT: http://review.gluster.org/12546 committed in master by Raghavendra G (rgowdapp) 
------
commit 38bfd4e43c42cbf2a8591b546b808c6ec811995f
Author: vmallika <vmallika>
Date:   Mon Nov 9 11:55:15 2015 +0530

    quota: fix spurious failure
    
    Change-Id: I5d18533d66df3175752a73430f680dcdfdb3c12a
    BUG: 1278689
    Signed-off-by: vmallika <vmallika>
    Reviewed-on: http://review.gluster.org/12546
    Tested-by: NetBSD Build System <jenkins.org>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Raghavendra G <rgowdapp>

Comment 8 Niels de Vos 2016-06-16 13:43:12 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.