Bug 1279085 (maxmind-geoip2) - Review Request: maxmind-geoip2 - GeoIP2 webservice and database API
Summary: Review Request: maxmind-geoip2 - GeoIP2 webservice and database API
Keywords:
Status: CLOSED NOTABUG
Alias: maxmind-geoip2
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: NotReady
Depends On: newtonsoft-json maxmind-db nsubstitude mockhttp
Blocks: openra
TreeView+ depends on / blocked
 
Reported: 2015-11-07 19:57 UTC by Raphael Groner
Modified: 2016-11-05 22:03 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-11-05 22:03:20 UTC


Attachments (Terms of Use)

Description Raphael Groner 2015-11-07 19:57:34 UTC
Spec URL: maxmind-geoip2.spec
SRPM URL: <srpm info here>
Description: GeoIP2 webservice and database API
Fedora Account System Username: raphgro

This is just a place holder for an upcoming package request.

Comment 1 Raphael Groner 2015-11-07 20:01:40 UTC
URL: https://maxmind.github.io/GeoIP2-dotnet/

Comment 2 Raphael Groner 2015-11-07 23:08:03 UTC
Spec URL: https://raphgro.fedorapeople.org/review/openra/maxmind-geoip2.spec
SRPM URL: https://raphgro.fedorapeople.org/review/openra/maxmind-geoip2-2.4.0-1.fc23.src.rpm
Description: GeoIP2 webservice and database API
Fedora Account System Username: raphgro

Comment 3 Matthias Mailänder 2015-11-25 14:53:06 UTC
We rely on MaxMind.GeoIP2 version 2.3.1 for OpenRA. An upgrade to 2.4.0 isn't easy, because it makes use of async features which require a whole new cascade of dependencies. https://www.nuget.org/packages/MaxMind.GeoIP2/

Comment 4 Matthias Mailänder 2015-12-29 09:19:58 UTC
An update to 2.5.0 is also not likely to succeed. https://github.com/OpenRA/OpenRA/pull/10280

Comment 5 Raphael Groner 2016-03-02 12:34:04 UTC
(In reply to Matthias Mailänder from comment #4)
> An update to 2.5.0 is also not likely to succeed.
> https://github.com/OpenRA/OpenRA/pull/10280

Is this still relevant? I see the linked PR is closed.

Comment 6 Matthias Mailänder 2016-03-02 19:31:33 UTC
It is currently help Fedora or keep Windows XP support by not doing the surrounding .NET 4.5 target upgrade. We have not resolved this yet. Sorry.

Comment 7 Raphael Groner 2016-03-02 19:50:35 UTC
(In reply to Matthias Mailänder from comment #6)
> It is currently help Fedora or keep Windows XP support by not doing the
> surrounding .NET 4.5 target upgrade. We have not resolved this yet. Sorry.

a. Fedora has *nothing* but *nothing* to do with XP!
b. You use prebuilt assemblies and libraries based on a newer .NET and some based on olders. Nuget is no option for Fedora that's completely based on FLOSS. Everything else is inacceptable for us.
c. Do you want to tell we should connect OpenRA into the bin?

Sorry, but that's no solution. Maybe you want to get rid of official Mono support in general?

Comment 8 Matthias Mailänder 2016-03-02 19:57:52 UTC
a) Fedora only supports .NET 4.5 as 4.0 is only supplied by pre-built binaries from Xamarin. Windows XP on the other only suppots .NET 4.0 as it EOLed a long time ago.
b) I am aware that NuGet isn't acceptable outside the Windows sphere. We haven't really established a good way of handling dependencies other than putting it in a ./thirdparty folder where you have to link system libraries.
c) I can't follow, but I guess we could need your help here to fix OpenRA's binary dependency problem.

Comment 9 Matthias Mailänder 2016-03-02 20:00:35 UTC
https://github.com/OpenRA/OpenRA/issues/10661 has the details.

Comment 10 Raphael Groner 2016-03-07 14:22:16 UTC
Hmm, new guideline modification may apply for the optionally pregenerated test data (maybe source1) and could need also the sources in srpm. Have to investigate.
https://fedoraproject.org/wiki/Packaging:Guidelines#Use_of_pregenerated_code

Comment 11 Matthias Mailänder 2016-08-08 05:32:03 UTC
Note: I updated the OpenRA development build to use the 2.6.0 MaxMind GeoIP version. https://github.com/OpenRA/OpenRA/pull/11285

Comment 12 Raphael Groner 2016-09-29 17:19:42 UTC
Matthias,
does OpenRA work also with the MaxMind GeoIP 2.7.x series?

Comment 13 Matthias Mailänder 2016-09-30 02:26:37 UTC
Yes https://github.com/OpenRA/OpenRA/pull/12132 but the .NET to .NET Core changes seem to cause NuGet dependency problems at least on Windows.

Comment 14 Raphael Groner 2016-11-05 22:03:20 UTC
.NET Core is currently no option for Fedora.


Note You need to log in before you can comment on or make changes to this bug.