Bug 1279197 (breeze-icon-theme) - Review Request: breeze-icon-theme - Breeze icon theme
Summary: Review Request: breeze-icon-theme - Breeze icon theme
Keywords:
Status: CLOSED NOTABUG
Alias: breeze-icon-theme
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2015-11-08 15:00 UTC by Daniel Vrátil
Modified: 2015-11-11 23:29 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-11-11 17:50:40 UTC
Type: ---
Embargoed:
rdieter: fedora-review+


Attachments (Terms of Use)

Description Daniel Vrátil 2015-11-08 15:00:17 UTC
Spec URL: https://dvratil.fedorapeople.org/plasma5/review/breeze-icon-theme.spec
SRPM URL: https://dvratil.fedorapeople.org/plasma5/review/breeze-icon-theme-5.16.0-1.fc22.src.rpm
Description: Breeze icon theme
Fedora Account System Username: dvratil

Comment 1 Rex Dieter 2015-11-08 15:10:48 UTC
Naming: ok

licensing: ok

sources: ok
649b3b20669d052abe3ebc639ef0c705  breeze-icons-5.16.0.tar.xz

scriptlets: ok

macros: ok

Otherwise, simple noarch pkg we're already packaging elsewhere (plasma-breeze currently).


APPROVED



non-blocking Suggestions:

1.   URL:  http://projects.kde.org/breeze-icons

2.  add
%ghost %{_datadir}/icons/breeze-dark/icon-theme.cache
too

3.  Source URL seems wrong, upstream doesn't have a src subdir for 5.16 it seems, so
Source0:        http://download.kde.org/%{stable}/frameworks/%{versiondir}/breeze-icons-%{version}.tar.xz
(for now, or poke them to fix it)

Comment 2 Gwyn Ciesla 2015-11-10 14:35:57 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/breeze-icon-theme

Comment 3 Rex Dieter 2015-11-11 17:50:40 UTC
imported (not built yet, waiting for plasma-5.5?)

Comment 4 Daniel Vrátil 2015-11-11 23:29:01 UTC
Built in rawhide, building for F22 and F23 now. Since it now has higher version number than breeze-icon-theme subpkg from plasma-breeze the upgrade path is OK and there won't be any conflict with current Plasma 5.4.x. The subpackage will be removed from plasma-breeze in Plasma 5.5 update.


Note You need to log in before you can comment on or make changes to this bug.