Bug 1279308 - upgrade should get the storageDirectory from master-config.yaml
Summary: upgrade should get the storageDirectory from master-config.yaml
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Cluster Version Operator
Version: 3.0.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: ---
Assignee: Devan Goodwin
QA Contact: Johnny Liu
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-11-09 05:59 UTC by Anping Li
Modified: 2015-11-19 23:29 UTC (History)
4 users (show)

Fixed In Version: openshift-ansible-3.0.7-1.git.156.70ed54c.el7aos
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-11-19 23:29:19 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2015:2492 0 normal SHIPPED_LIVE Red Hat OpenShift Enterprise 3.1 upgrade support enhancement 2015-11-20 03:10:38 UTC

Description Anping Li 2015-11-09 05:59:44 UTC
Description of problem:
If we didn't use the default etcd storage location,  upgrade will abort in the task "Generate etcd backup".
In fact, the etcd storage location was recorded in master-config.yaml. it is better to get the etcd storage location from config file rather that use the default values.


Version-Release number of selected component (if applicable):
atomic-openshift-utils.noarch 0:3.0.7

How reproducible:
always

Steps to Reproduce:
1. change the openshift to use different etcd storage locations in master config file.
2. upgrade using ansible playbook


Actual results:
TASK: [Generate etcd backup] ************************************************** 
failed: [10.3.8.193] => {"changed": true, "cmd": ["etcdctl", "backup", "--data-dir=/var/lib/openshift/openshift.local.etcd", "--backup-dir=/var/lib/openshift/etcd-backup-20151107172308"], "delta": "0:00:00.015862", "end": "2015-11-07 04:23:07.176924", "rc": 1, "start": "2015-11-07 04:23:07.161062", "warnings": []}
FATAL: all hosts have already failed -- aborting

PLAY RECAP ******************************************************************** 
           to retry, use: --limit @/root/upgrade.retry

10.3.8.193                 : ok=15   changed=4    unreachable=0    failed=1   
localhost                  : ok=3    changed=0    unreachable=0    failed=0   

Expected results:

The upgrade success.
ansible could get etcd storage location from master configuration files.

Additional info:

Comment 1 Jason DeTiberus 2015-11-09 06:04:28 UTC
Just an additional note:
For embedded etcd getting the storage location from master-config.yaml will not be an issue.

If using an external etcd, then we will probably want to query the etcd config on oo_first_etcd

Comment 2 Devan Goodwin 2015-11-09 19:23:36 UTC
Fixed in https://github.com/openshift/openshift-ansible/pull/850

The standalone etcd dir was dead wrong in first version as well, so this is much better.

Comment 4 Anping Li 2015-11-10 11:31:56 UTC
Verified and pass in openshift-ansible-3.0.7-1.git.156.70ed54c.el7aos

Comment 6 errata-xmlrpc 2015-11-19 23:29:19 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2015:2492


Note You need to log in before you can comment on or make changes to this bug.