Bug 1279398 - [RFE] [admin portal] Sort ISOs from ISO domain in lists in natural (version) sort order
Summary: [RFE] [admin portal] Sort ISOs from ISO domain in lists in natural (version) ...
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Hardware: Unspecified
OS: Unspecified
Target Milestone: ovirt-4.0.0-beta
: 4.0.0
Assignee: Idan Shaby
QA Contact: Elad
Depends On:
TreeView+ depends on / blocked
Reported: 2015-11-09 11:33 UTC by Jiri Belka
Modified: 2016-07-18 01:38 UTC (History)
10 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
ISO domain files are sorted alphabetically in the Administration portal. This update additionally enables the sorting to take version numbers into consideration. A file named RHEV_3.5.10.iso will now come after a file named RHEV_3.5.5.iso and not before it.
Clone Of:
Last Closed: 2016-07-05 08:05:04 UTC
oVirt Team: Storage
rule-engine: ovirt-4.0.0+
gklein: testing_plan_complete-
ylavi: planning_ack+
masayag: devel_ack+
acanan: testing_ack+

Attachments (Terms of Use)
screenshot (237.17 KB, image/png)
2015-11-09 11:33 UTC, Jiri Belka
no flags Details
Verification screenshots (58.87 KB, image/png)
2016-05-24 10:34 UTC, Elad
no flags Details

System ID Private Priority Status Summary Last Updated
oVirt gerrit 55948 0 master MERGED webadmin: improve repo images sort 2016-04-12 07:29:38 UTC

Description Jiri Belka 2015-11-09 11:33:33 UTC
Created attachment 1091692 [details]

Description of problem:

[admin portal] Sort isos in lists in natural (version) sort order, so 3.5.10 is not after 3.5.1 but after 3.5.9 for example. Same wasy as `sort -V' does it.

* currently

RHEV 3.5.1
RHEV 3.5.10
RHEV 3.5.3

* proposition (like `cat /tmp/test | sort -V')

RHEV 3.1.0
RHEV 3.5.1
RHEV 3.5.3
RHEV 3.5.10

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. have some files in iso domain which contain .1, .[2-9] and .10 as last digit in filename
2. check where is .10 in the list

Actual results:
not naturally (version) sorted

Expected results:
naturally (version) sorted

Additional info:

Comment 3 Moti Asayag 2015-11-11 08:06:46 UTC
(In reply to Moti Asayag from comment #2)
> (In reply to Einav Cohen from comment #1)
> > please refer to http://etherpad.corp.redhat.com/whiteboard when filling
> > Whiteboard. 'ui' doesn't exist even. thanks.
> Changed whiteboard to 'infra', since it is related to ovirt-node isos, not
> to storage domain.

And moving back to 'storage', as the ovirt-isos are already sorted properly and seems not to be a concern for this bug.

Comment 4 Elad 2016-05-24 10:34:13 UTC
ISOs are sorted naturally in Run Virtual Machine prompt.

Used: ovirt-engine-4.0.0-0.0.master.20160523171412.git1a7a1f3.el7.centos.noarch

Attaching screenshot.

Comment 5 Elad 2016-05-24 10:34:45 UTC
Created attachment 1160979 [details]
Verification screenshots

Comment 6 Sandro Bonazzola 2016-07-05 08:05:04 UTC
oVirt 4.0.0 has been released, closing current release.

Note You need to log in before you can comment on or make changes to this bug.