Bug 1279407 - [admin portal] When importing a VM, the default storage domain should have enough space to perform the import
Summary: [admin portal] When importing a VM, the default storage domain should have en...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 3.6.0.2
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ovirt-4.1.0-beta
: 4.1.0.2
Assignee: Idan Shaby
QA Contact: Eyal Shenitzky
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-11-09 11:52 UTC by Jiri Belka
Modified: 2017-02-01 14:47 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-02-01 14:47:18 UTC
oVirt Team: Storage
Embargoed:
rule-engine: ovirt-4.1+
rule-engine: planning_ack+
tnisan: devel_ack+
ratamir: testing_ack+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 70635 0 ovirt-engine-4.1 MERGED webadmin: default storage domain on VM import 2017-01-17 12:37:02 UTC
oVirt gerrit 70641 0 ovirt-engine-4.1 MERGED webadmin: default storage domain on VM import 2017-01-17 13:46:24 UTC

Description Jiri Belka 2015-11-09 11:52:46 UTC 
Description of problem:

[admin portal] When importing a VM Default storage domain should be one with biggest free space. I regularly import a VM on our first storage domain (alphanum sorted) which in almost full and thus import fails.

It seems 'Default' is also superfluous word in the Import VM dialog on storage line.

Version-Release number of selected component (if applicable):
rhevm-webadmin-portal-3.6.0.2-0.1.el6.noarch

How reproducible:
100%

Steps to Reproduce:
1. have two storage domains, A and B
2. have A almost full so imported VM won't fit
3. import VM from an export domain and don't change anything

Actual results:
a VM being imported is copied onto almost full A storage domain

Expected results:
by default let's propose storage domain with biggest free space, an user could change it to his likes if needed

Additional info:
Comment 1 Allon Mureinik 2015-11-10 06:08:31 UTC 
Not sure I'd necessarily go with the domain with the most free space, but having a domain you can't import to as the default target is definitely a bug.
Comment 2 Idan Shaby 2016-02-22 11:44:04 UTC 
Eldan, can we get your two cents about this?
What is the right approach here? Maybe we can filter out from the list the domains that don't have enough space for the import?
Comment 3 Eldan Hildesheim 2016-03-10 12:41:45 UTC 
I tend to agree with Allon.
But, to prevent choosing from a low capacity domain, I would add to each domain name in brackets, how much free space available.

Storage1 (Free 1GB)
Storage2 (Free 2GB)
...
Comment 4 Eyal Shenitzky 2017-01-24 08:16:15 UTC 
(In reply to Idan Shaby from comment #2)
> Eldan, can we get your two cents about this?
> What is the right approach here? Maybe we can filter out from the list the
> domains that don't have enough space for the import?

Can you pls provide steps in order to verify this bug, I'm not sure what the expected results suppose to be here.
Comment 5 Idan Shaby 2017-01-24 08:38:52 UTC 
Sure, I didn't touch the list of storage domains at all, only changed the default selection of the storage domain, as the title claims, to be the one with the most free space among all the domains in the list.
Comment 6 Eyal Shenitzky 2017-01-25 07:17:01 UTC 
 Verified with the following code:
------------------------------------------
rhevm-4.1.0.2-0.1.el7

Verified with the following scenario:
------------------------------------------
Steps to reproduce:
------------------------------------------
1. have two storage domains, A and B
2. Export VM to export domain
3. Import VM from an export domain

Result: Default storage domain was the one with 
the most free space.

Moving to VERIFIED
Note You need to log in before you can comment on or make changes to this bug.