Red Hat Bugzilla – Bug 1280343
Review Request: perl-Text-Bidi - Unicode bidirectional algorithm using libfribidi
Last modified: 2015-11-16 10:14:30 EST
Spec URL: https://ppisar.fedorapeople.org/perl-Text-Bidi/perl-Text-Bidi.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Text-Bidi/perl-Text-Bidi-2.11-1.fc24.src.rpm
This Perl module provides basic support for the Unicode bidirectional (Bidi)
text algorithm, for displaying text consisting of both left-to-right and
right-to-left written languages (such as Hebrew and Arabic.) It does so via
a SWIG interface file to the libfribidi library.
Fedora Account System Username: ppisar
I updated to package. After discussion with upstream, I install the misc/bidi file into urxvt plugin directory and I package it into a sub-package.
* Since you chose the pkgconfig() approach, the build dependency on
fribidi-devel seems rather pointless.
* Data::Dumper, and version are only used by the disabled t/ucd.t test.
You can drop these build deps for now.
* I don't think the urxvt subpackage strictly requires the base package
in this case and were it me, I would drop this dependency.
If you decide to do this, don't forget to add the license text to the
subpackage as well.
* The package doesn't build in mock.
psabata's scratch build of perl-Text-Bidi-2.11-1.fc24.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11819387
(In reply to Petr Šabata from comment #2)
> * The package doesn't build in mock.
Correction -- sometimes it does. It's just unpredictable.
It could have something to do with the parallel build.
I implemented all the changes. I kept parallel built so far.
Acking all the changes.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/perl-Text-Bidi
Thank you for the review and the repository.