Bug 1281245 - Review Request: perl-DBIx-Class-DeploymentHandler - Extensible DBIx::Class deployment
Summary: Review Request: perl-DBIx-Class-DeploymentHandler - Extensible DBIx::Class de...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-11-12 06:47 UTC by Emmanuel Seyman
Modified: 2015-11-12 16:07 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-11-12 16:07:27 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Emmanuel Seyman 2015-11-12 06:47:20 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-DBIx-Class-DeploymentHandler/perl-DBIx-Class-DeploymentHandler.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-DBIx-Class-DeploymentHandler/perl-DBIx-Class-DeploymentHandler-0.002218-1.fc22.src.rpm
Description:
DBIx::Class::DeploymentHandler is, as its name suggests, a tool for deploying
and upgrading databases with DBIx::Class. It is designed to be much more
flexible than DBIx::Class::Schema::Versioned, hence the use of Moose and lots
of roles.

Fedora Account System Username: eseyman
Rpmlint output: 1 packages and 1 specfiles checked; 0 errors, 0 warnings.

Comment 1 Upstream Release Monitoring 2015-11-12 08:13:39 UTC
jplesnik's scratch build of perl-DBIx-Class-DeploymentHandler-0.002218-1.fc22.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11800828

Comment 2 Jitka Plesnikova 2015-11-12 12:23:15 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --provides perl-DBIx-Class-DeploymentHandler-0.002218-1.fc24.noarch.rpm | sort | uniq -c
      1 perl(DBIx::Class::DeploymentHandler) = 0.002218
      1 perl(DBIx::Class::DeploymentHandler::Dad) = 0.002218
      1 perl(DBIx::Class::DeploymentHandler::DeployMethod::SQL::Translator) = 0.002218
      1 perl(DBIx::Class::DeploymentHandler::DeployMethod::SQL::Translator::Deprecated) = 0.002218
      1 perl(DBIx::Class::DeploymentHandler::DeployMethod::SQL::Translator::ScriptHelpers) = 0.002218
      1 perl(DBIx::Class::DeploymentHandler::Deprecated) = 0.002218
      1 perl(DBIx::Class::DeploymentHandler::HandlesDeploy) = 0.002218
      1 perl(DBIx::Class::DeploymentHandler::HandlesVersionStorage) = 0.002218
      1 perl(DBIx::Class::DeploymentHandler::HandlesVersioning) = 0.002218
      1 perl(DBIx::Class::DeploymentHandler::LogImporter) = 0.002218
      1 perl(DBIx::Class::DeploymentHandler::LogRouter) = 0.002218
      1 perl(DBIx::Class::DeploymentHandler::Logger) = 0.002218
      1 perl(DBIx::Class::DeploymentHandler::Types) = 0.002218
      1 perl(DBIx::Class::DeploymentHandler::VersionHandler::DatabaseToSchemaVersions) = 0.002218
      1 perl(DBIx::Class::DeploymentHandler::VersionHandler::ExplicitVersions) = 0.002218
      1 perl(DBIx::Class::DeploymentHandler::VersionHandler::Monotonic) = 0.002218
      1 perl(DBIx::Class::DeploymentHandler::VersionStorage::Deprecated) = 0.002218
      1 perl(DBIx::Class::DeploymentHandler::VersionStorage::Deprecated::Component) = 0.002218
      1 perl(DBIx::Class::DeploymentHandler::VersionStorage::Deprecated::VersionResult) = 0.002218
      1 perl(DBIx::Class::DeploymentHandler::VersionStorage::Deprecated::VersionResultSet) = 0.002218
      1 perl(DBIx::Class::DeploymentHandler::VersionStorage::Standard) = 0.002218
      1 perl(DBIx::Class::DeploymentHandler::VersionStorage::Standard::Component) = 0.002218
      1 perl(DBIx::Class::DeploymentHandler::VersionStorage::Standard::VersionResult) = 0.002218
      1 perl(DBIx::Class::DeploymentHandler::VersionStorage::Standard::VersionResultSet) = 0.002218
      1 perl(DBIx::Class::DeploymentHandler::WithApplicatorDumple) = 0.002218
      1 perl(DBIx::Class::DeploymentHandler::WithReasonableDefaults) = 0.002218
      1 perl-DBIx-Class-DeploymentHandler = 0.002218-1.fc24
Binary provides are Ok.

$ rpm -qp --requires perl-DBIx-Class-DeploymentHandler-0.002218-1.fc24.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.22.0)
      1 perl(Carp)
      1 perl(Carp::Clan)
      1 perl(Context::Preserve)
      1 perl(DBIx::Class::Core)
      1 perl(DBIx::Class::DeploymentHandler::LogImporter)
      1 perl(DBIx::Class::DeploymentHandler::LogRouter)
      1 perl(DBIx::Class::DeploymentHandler::Logger)
      1 perl(DBIx::Class::DeploymentHandler::Types)
      1 perl(DBIx::Class::DeploymentHandler::VersionStorage::Deprecated::VersionResult)
      1 perl(DBIx::Class::DeploymentHandler::VersionStorage::Standard::VersionResult)
      1 perl(DBIx::Class::ResultSet)
      1 perl(DBIx::Class::Schema)
      1 perl(DBIx::Class::Storage)
      1 perl(File::Spec::Functions)
      1 perl(List::Util)
      1 perl(Log::Contextual)
      1 perl(Log::Contextual::WarnLogger)
      1 perl(Module::Runtime)
      1 perl(Moo)
      1 perl(Moose)
      1 perl(Moose::Role)
      1 perl(Moose::Util)
      1 perl(Moose::Util::TypeConstraints)
      1 perl(MooseX::Role::Parameterized)
      1 perl(Path::Class)
      1 perl(SQL::Translator)
      1 perl(SQL::Translator::Diff)
      1 perl(Sub::Exporter::Progressive)
      1 perl(Text::Brew)
      1 perl(Time::HiRes)
      1 perl(Try::Tiny)
      1 perl(autodie)
      1 perl(namespace::autoclean)
      1 perl(parent)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1

FIX: Please add run requires:
- perl(Log::Contextual::Role::Router) - lib/DBIx/Class/DeploymentHandler/LogRouter.pm:6
- perl(DBIx::Class::Schema::Loader) - lib/DBIx/Class/DeploymentHandler/DeployMethod/SQL/Translator/ScriptHelpers.pm:58


$ rpmlint ./perl-DBIx-Class-DeploymentHandler*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Rpmlint is ok

BuildRequires are almost ok
FIX: Please add constrain to perl(Test::Pod) >= 1.41

Please correct all 'FIX' issues.
Otherwise the package looks good.
APPROVED.

Comment 3 Emmanuel Seyman 2015-11-12 13:15:33 UTC
(In reply to Jitka Plesnikova from comment #2)
> 
> FIX: Please add run requires:
> - perl(Log::Contextual::Role::Router) -
> lib/DBIx/Class/DeploymentHandler/LogRouter.pm:6
> - perl(DBIx::Class::Schema::Loader) -
> lib/DBIx/Class/DeploymentHandler/DeployMethod/SQL/Translator/ScriptHelpers.
> pm:58

I had added these at the last minute to the spec file but forgot to rebuild the source package. I'll keep them. :-)

> $ rpmlint ./perl-DBIx-Class-DeploymentHandler*
> BuildRequires are almost ok
> FIX: Please add constrain to perl(Test::Pod) >= 1.41

Added.

I've requested SCM for devel, f23 and f22.

Comment 4 Gwyn Ciesla 2015-11-12 14:57:42 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/perl-DBIx-Class-DeploymentHandler

Comment 5 Emmanuel Seyman 2015-11-12 16:07:27 UTC
Imported and built in rawhide.


Note You need to log in before you can comment on or make changes to this bug.