Spec URL: https://jplesnik.fedorapeople.org/perl-Unix-Mknod/perl-Unix-Mknod.spec SRPM URL: https://jplesnik.fedorapeople.org/perl-Unix-Mknod/perl-Unix-Mknod-0.04-1.fc24.src.rpm Description: This module allows access to the device routines major()/minor()/makedev() that may or may not be macros in .h files. Fedora Account System Username: jplesnik
* Tip: You may drop the coreutils build time dependency if you substitute the `-exec rm -f {} \;' but with `-delete'. * Tip: The Group tag isn't really needed nowadays. * As this is an XS package, you should also BR gcc and perl-devel. * I'm not sure the license could be really considered `MIT'; it looks like a combination of `MIT' and `BSD' (3-clause). I suggest you check with legal.
(In reply to Petr Šabata from comment #1) > * Tip: You may drop the coreutils build time dependency if you substitute > the `-exec rm -f {} \;' but with `-delete'. Done > * Tip: The Group tag isn't really needed nowadays. Group removed > * As this is an XS package, you should also BR gcc and perl-devel. Added > * I'm not sure the license could be really considered `MIT'; it looks like a > combination of `MIT' and `BSD' (3-clause). I suggest you check with legal. License is NCSA https://lists.fedoraproject.org/pipermail/legal/2015-November/002717.html Updated files: https://jplesnik.fedorapeople.org/perl-Unix-Mknod/perl-Unix-Mknod.spec https://jplesnik.fedorapeople.org/perl-Unix-Mknod/perl-Unix-Mknod-0.04-2.fc24.src.rpm
(In reply to Jitka Plesnikova from comment #2) > (In reply to Petr Šabata from comment #1) > > * Tip: The Group tag isn't really needed nowadays. > Group removed Not really but it doesn't matter. The rest is fine now. Approving.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/perl-Unix-Mknod
Thank you for the review and the repository.