Spec URL: https://smani.fedorapeople.org/review/fusion-qt4.spec SRPM URL: https://smani.fedorapeople.org/review/fusion-qt4-hg20151112-1.fc24.src.rpm Description: Fusion widget style for Qt4 Fedora Account System Username: smani Note: qstylehelper.cpp is taken from the Qt4 sources, but since Qt4 won't receive any updates anymore, this shouldn't be an issue really.
I can review this.
1. Naming: ok, but SHOULD follow practice of some other styles using something like: qt4-style-fusion 2. Version/Release: SHOULD: I'd also prefer you used something closer to recommendations on http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Versioning like: Version: 0 Release: 1.hg20151112 (or some better Version: if you have a better idea) 3. Sources: not ok. MUST: sources not verifiable, please give url or script/directions on how to create reproduciable sources 4. macros, mostly ok, except for SHOULD replace %make_install INSTALL_ROOT=%{buildroot} with make install INSTALL_ROOT=%{buildroot} 5. Since this package is using qt4-devel-private, SHOULD consider adding a hard versioned dep like: %{?_qt4_version:Requires: qt4%{?_isa} = %{_qt4_version}} though probably not important anymore, there's little chance of any new qt4 releases at this point.
Spec URL: https://smani.fedorapeople.org/review/qt4-style-fusion.spec SRPM URL: https://smani.fedorapeople.org/review/qt4-style-fusion-0-1.hg20151214.fc24.src.rpm
Looks good, thanks. APPROVED
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/qt4-style-fusion
qt4-style-fusion-0-1.hg20151214.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-1fb6219c44
qt4-style-fusion-0-1.hg20151214.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-45ea4be3ce
qt4-style-fusion-0-1.hg20151214.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update qt4-style-fusion' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-1fb6219c44
qt4-style-fusion-0-1.hg20151214.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-45ea4be3ce
qt4-style-fusion-0-1.hg20151214.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
qt4-style-fusion-0-1.hg20151214.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.