Red Hat Bugzilla – Bug 1283749
Some GUI dialogs which should be error dialogs are information dialogs, breaking automated testing
Last modified: 2017-03-21 06:53:59 EDT
Description of problem:
Starting with at least the subscription-manager-gui-1.16.4-1.git.0.c250102.el6.x86_64 code base, when some actions are followed up by dialogs, the dialog boxes are info dialogs rather than error dialogs.
The inconsistency between popping up info or dialog windows breaks automation tests which assumes that if an info dialog pops up, things are ok. Here are some examples:
Register with an empty username
Register with an empty password
Register without a system name
However, some fields when missing any text throw an error dialog. For example, failing to enter any text for the subscription server results in an error dialog box. Also, entering incorrect user/pw combo results in an error dialog.
However, missing fields should be treated the same as errors...meaning that the user has entered incorrect information (as is correctly done when no subscription URL is provided).
Version-Release number of selected component (if applicable):
[root@rhel67-stoner-test ~]# rpm -qa | grep subscription
Steps to Reproduce:
1. In the GUI, leave the username blank
2. Notice the Icon is a light bulb indicating an info dialog box
An information dialog box shows up to inform user of problem
An error dialog box should show up to inform user of problem
Created attachment 1096833 [details]
information dialog when username is blank
Screenshot of an information dialog that is presented when the user leaves the username field blank
Author: William Poteat <email@example.com>
Date: Mon Jan 4 12:02:08 2016 -0500
1283749: Upgrade the dialogs to error when required fields are blank.
Also corrected a couple of stylish issues.
This bug was accidentally moved from POST to MODIFIED via an error in automation, please see firstname.lastname@example.org with any questions
The dialogs are still showing up as Informational type dialogs (see attached screenshot). Not only does the dialog still show up as an Informational type dialog but the locator name still says "Informational" (see attached screenshot)
Ultimately, the way that we determine if a dialog is an error type dialog or not is by looking at the locator name. The ldtp tool that we use has a property called "class" for a window, but it always returns "alert" whether it's an info type dialog, or error type dialog.
Created attachment 1148703 [details]
Still has an information dialog
Deferring to rhel 6.9 as the fix did not pass qa.
master commit 85fb4d6c5988b15f72b8d5cfd24e2f63041765d2
Created attachment 1217363 [details]
error dialog when password is blank
Created attachment 1217364 [details]
Error dialog when username is blank
Moving bug to verified state as I see the error dialogues while attempting to register using blank username and password
[root@dhcp35-71 ~]# subscription-manager version
server type: Red Hat Subscription Management
subscription management server: 0.9.51.20-1
subscription management rules: 5.15.1
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.