Hey, thanks for packaging this. Here are some comments.

(In reply to Igor Gnatenko from comment #0)
> Spec URL:
> https://ignatenkobrain.fedorapeople.org/for-review/wayland-protocols.spec
> SRPM URL:
> https://ignatenkobrain.fedorapeople.org/for-review/wayland-protocols-0.1.0-0.
> gitf828a43.fc24.src.rpm

I don't think a git version of wayland-protocols should ever be installed anywhere, but that's easy to avoid now since version 1.0 was released yesterday. So I think an initial packaging should be the 1.0 release.

There is no build-req for gcc.

The URL should IMHO be http://wayland.freedesktop.org.

No need to do autoreconf etc, since you'd use the tar.xz as source. There is also no need for running "make" because it wouldn't do anything anyway.

The XML files should be part of the -devel package.

I think it might be enough with only a -devel package. As of now, wayland-protocols is only ever needed as a build requirement and there is no reason to having it installed in any form. In the future maybe a -doc package makes sense, but we don't have relevant documentation to install yet. I'm not sure I see a point in distributing the toplevel README file in a -doc package, but rather the to be generated protocol documentation HTML files.

> Description:
> wayland-protocols contains Wayland protocols that adds functionality not
> available in the Wayland core protocol. Such protocols either adds
> completely new functionality, or extends the functionality of some other
> protocol either in Wayland core, or some other protocol in
> wayland-protocols.
> 
> A protocol in wayland-protocols consists of a directory containing a set
> of XML files containing the protocol specification, and a README file
> containing detailed state and a list of maintainers.
> Fedora Account System Username: ignatenkobrain

This second paragraph is only relevant for people looking in the repository, so I think it should be dropped. We currently do not install the README files.

Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/wayland-protocols.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/wayland-protocols-1.0.fc24.src.rpm


Fixed.

Taking for review.

kalev's scratch build of wayland-protocols-1.0-1.fc24.src.rpm for f24 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12058568

Fedora review wayland-protocols-1.0-1.fc24.src.rpm 2015-12-04

$ rpmlint wayland-protocols-1.0-1.fc24.src.rpm \
          wayland-protocols-devel
wayland-protocols.src: E: summary-too-long C Wayland protocols that adds functionality not available in the Wayland core protocol
2 packages and 0 specfiles checked; 1 errors, 0 warnings.

+ OK
! needs attention

! rpmlint warnings:

  Would be good to fix up the summary-tool-long warning. I'd suggest "Wayland protocol files" as the new summary.

+ The package is named according to Fedora packaging guidelines
+ The spec file name matches the base package name.
+ The package meets the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
  Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The license text (COPYING) is included in %license
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match the sources in the srpm
  1ee04fc828cffaf278fdc684a13981eb  wayland-protocols-1.0.tar.xz
  1ee04fc828cffaf278fdc684a13981eb  Download/wayland-protocols-1.0.tar.xz
+ The package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane

  We don't usually specify 'make' explicitly, but it's fine to have it too if you want to list that.

n/a locale handling
n/a ldconfig in %post and %postun
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
+ Package owns all the directories it creates
+ No duplicate files in %files
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect the runtime of application
n/a Static libraries should be in -static
+ Development files should be in -devel
n/a -devel must require the fully versioned base
+ Packages should not contain libtool .la files
n/a Proper .desktop file handling
+ Doesn't own files or directories already owned by other packages
+ Filenames are valid UTF-8


Some other nitpicks I noticed:

> Requires:       pkgconfig

rpmbuild autogenerates a dep on /usr/bin/pkg-config and there's no need to manually list "Requires: pkgconfig"

> %make_build

Like Jonas says above, this isn't really needed for this package as it's not building anything.


Another thing I noticed is that now that you are only building a wayland-protocols-devel and there's no wayland-protocols package, all the nicely written summaries are essentially not used in the actual user visible package -- the -devel subpackage only has a copy-pasted one line blurb. It's also somewhat misleading to say "Development files for %{name}" because there's no '%{name}' package.


None of these are blocking issues for the review, but please feel free to address them before importing.

APPROVED

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/wayland-protocols

wayland-protocols-1.0-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-ccfb0585fe

wayland-protocols-1.0-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update wayland-protocols'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-ccfb0585fe

wayland-protocols-1.0-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.