Bug 1284423 - gmock-devel missing Requires: gtest-devel
Summary: gmock-devel missing Requires: gtest-devel
Keywords:
Status: CLOSED DUPLICATE of bug 1314927
Alias: None
Product: Fedora
Classification: Fedora
Component: gmock
Version: 24
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Terje Røsten
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-11-23 10:16 UTC by Dominik 'Rathann' Mierzejewski
Modified: 2016-10-02 13:40 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-10-02 13:40:20 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Dominik 'Rathann' Mierzejewski 2015-11-23 10:16:02 UTC
Description of problem:
gmock-devel package is missing Requires: gtest-devel leading to the following errors when compiling code which uses gmock.h:

[...]
gtest/internal/gtest-linked_ptr.h: No such file or directory
[...]

The gtest headers gtest-linked_ptr.h and gtest-port.h are referenced in /usr/include/gmock/internal/gmock-port.h:45
[...]
// Most of the types needed for porting Google Mock are also required
// for Google Test and are defined in gtest-port.h.
#include "gtest/internal/gtest-linked_ptr.h"
#include "gtest/internal/gtest-port.h"
[...]

Version-Release number of selected component (if applicable):
gmock-1.7.0-2.fc23.noarch

Comment 1 Terje Røsten 2015-11-23 18:53:52 UTC
I don't think gtest is a strict requirement for gmock:

 https://github.com/google/googletest/blob/master/googlemock/README.md

Google Mock works seamlessly with Google Test, butj you can also use it with any C++ testing framework.

I might be wrong, well, well, adding a dep is not that problematic any way.

However, in what software are you seeing this issue?

Comment 2 Dominik 'Rathann' Mierzejewski 2015-11-23 20:05:44 UTC
While I still think this bug report is valid in principle (you could at least add Recommends: gtest-devel), the current upstream was merged with gtest (see https://github.com/google/googlemock), so it's kind of moot. The bigger issue is that gtest in Fedora is built as a shared library and gmock is not, and - contrary to the Packaging Guidelines (https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Header_Only_Libraries) doesn't have Provides: gmock-static . Also, what is the gmock main package for? It contains nothing but documentation, which should be moved to gmock-devel as well.

I encountered the issue when trying to unbundle gmock from gromacs. Could you advise how I can do that with current gmock/gtest Fedora packaging? Upstream recommends just putting gmock and gtest sources in the consuming project source tree and I can't do that with current gmock/gtest packaging.

Comment 3 Jan Kurik 2016-02-24 14:01:02 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 24 development cycle.
Changing version to '24'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora24#Rawhide_Rebase

Comment 4 Terje Røsten 2016-10-02 13:40:20 UTC

*** This bug has been marked as a duplicate of bug 1314927 ***


Note You need to log in before you can comment on or make changes to this bug.