Bug 1284696 – config set with negative value results in "error setting 'filestore_merge_threshold' to '-40': (22) Invalid argument"

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1284696 - config set with negative value results in "error setting 'filestore_merge_threshold' to '-40': (22) Invalid argument"

Summary:	config set with negative value results in "error setting 'filestore_merge_thr...

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Ceph Storage
Classification:	Red Hat
Component:	RADOS (Show other bugs)
Sub Component:
Version:	1.3.1
Hardware:	x86_64 Linux

Priority	medium Severity medium
Target Milestone:	rc
Target Release:	1.3.3
Assigned To:	Brad Hubbard
QA Contact:	Vasishta
Docs Contact:	Bara Ancincova

URL:
Whiteboard:
Keywords:	Patch

Depends On:
Blocks:	1348597 1372735
	Show dependency tree / graph

Reported:	2015-11-23 18:08 EST by Brad Hubbard
Modified:	2017-07-30 11:13 EDT (History)
CC List:	9 users (show)

See Also:
Fixed In Version:
Doc Type:	Bug Fix
Doc Text:	."filestore_merge_threshold" can be set to a negative value as expected If the `filestore_merge_threshold` parameter is set to a negative value, merging of subdirectories is disabled. Previously, an attempt to set `filestore_merge_threshold` to a negative value by using the command line failed and an error message similar to the following one was returned: ---- "error": "error setting 'filestore_merge_threshold' to '-40': (22) Invalid argument" ---- As a consequence, it was not possible to disable merging of subdirectories. This bug has been fixed, and `filestore_merge_threshold` can now be set to a negative value as expected.
Story Points:	---
Clone Of:
Environment:
Last Closed:	2016-09-29 08:55:13 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Knowledge Base (Solution)	2055153	None	None	None	Never
Ceph Project Bug Tracker	13829	None	None	None	Never
Red Hat Product Errata	RHSA-2016:1972	normal	SHIPPED_LIVE	Moderate: Red Hat Ceph Storage 1.3.3 security, bug fix, and enhancement update	2016-09-29 12:51:21 EDT

Groups: None (edit)

Description Brad Hubbard 2015-11-23 18:08:29 EST

Description of problem:

In the filestore-config-ref we say...

    filestore merge threshold
    Description: Min number of files in a subdir before merging into parent NOTE: A > negative value means to disable subdir merging

But running the following gives an error.

# ceph --admin-daemon /var/run/ceph/ceph-osd.312.asok config set filestore_merge_threshold -40
{
    "error": "error setting 'filestore_merge_threshold' to '-40': (22) Invalid argument" 
}

Version-Release number of selected component (if applicable):
ceph-0.94.3-3.el7cp.x86_64

How reproducible:
100%

Steps to Reproduce:
1. ceph --admin-daemon /var/run/ceph/ceph-osd.312.asok config set filestore_merge_threshold -40


Actual results:
"error": "error setting 'filestore_merge_threshold' to '-40': (22) Invalid argument"

Expected results:
"success": "filestore_merge_threshold = '-40' "

Additional info:
This is being worked in http://tracker.ceph.com/issues/13829

Comment 1 Brad Hubbard 2016-01-31 23:54:00 EST

Upstream patch https://github.com/badone/ceph/commit/8b777a0c346bc70fd10d07e89368b3785b58f10e

Comment 2 Brad Hubbard 2016-02-08 17:02:02 EST

Merged and back-ported to Hammer upstream.

Comment 3 Mike McCune 2016-03-28 18:20:08 EDT

This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune@redhat.com with any questions

Comment 4 Vikhyat Umrao 2016-07-13 06:55:40 EDT

Brad, buddy could you please post hammer backport link.

Comment 5 Brad Hubbard 2016-07-13 19:35:56 EDT

Not sure how this got overlooked but I guess I didn't fully understand the process involved at that time.

I've created http://tracker.ceph.com/issues/16680 and am working on a backport now.

Comment 6 Brad Hubbard 2016-07-13 23:11:00 EDT

PR is here, https://github.com/ceph/ceph/pull/10291

Comment 7 Vikhyat Umrao 2016-07-14 01:29:11 EDT

Thanks Brad.

Comment 18 Vasishta 2016-09-14 13:34:29 EDT

Fix is working as required -
$ sudo ceph --admin-daemon /var/run/ceph/ceph-osd.3.asok config set filestore_merge_threshold -40
{
    "success": "filestore_merge_threshold = '-40' "
}
$
$ sudo ceph --admin-daemon /var/run/ceph/ceph-osd.5.asok config set filestore_merge_threshold -25
{
    "success": "filestore_merge_threshold = '-25' "
}

Regards,
Vasishta

Comment 20 Brad Hubbard 2016-09-20 21:25:33 EDT

Changed filestore_merge_treshold to filestore_merge_threshold in several places but apart from that looks good to me.

Comment 21 Brad Hubbard 2016-09-20 21:27:29 EDT

Flags: requires_doc_text+ → requires_doc_text?

Not sure why this happened?

Comment 25 errata-xmlrpc 2016-09-29 08:55:13 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-1972.html

Note You need to log in before you can comment on or make changes to this bug.