Bug 1284781 - Smart variable with space in its name allowed to create. Actually It should not.
Smart variable with space in its name allowed to create. Actually It should not.
Product: Red Hat Satellite 6
Classification: Red Hat
Component: Provisioning (Show other bugs)
Unspecified Unspecified
unspecified Severity medium (vote)
: GA
: --
Assigned To: orabin
Katello QA List
: Triaged
Depends On: 1324632
Blocks: 1278718
  Show dependency treegraph
Reported: 2015-11-24 03:45 EST by Jitendra Yejare
Modified: 2016-07-27 07:22 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2016-07-27 07:22:27 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
Screenshot Attached. (212.12 KB, image/png)
2015-11-24 03:45 EST, Jitendra Yejare
no flags Details
[Verified] Screenshot Attached (68.18 KB, image/png)
2016-05-19 08:45 EDT, Jitendra Yejare
no flags Details

External Trackers
Tracker ID Priority Status Summary Last Updated
Foreman Issue Tracker 12577 None None None 2016-04-22 11:35 EDT

  None (edit)
Description Jitendra Yejare 2015-11-24 03:45:17 EST
Created attachment 1098065 [details]
Screenshot Attached.

Description of problem:
Smart Variable with space in its name allowed to create in a puppet class. Which should not be allowed.
And also after creating the smart variable, it is not viewable, editable and deletable too.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. Try to create a smart variable with name having blank space, from Config -> Classes -> Class -> Smart Variables tab.

Actual results:
Smart Variable with space in its name allowed to create in a puppet class.

Expected results:
1.Smart Variable with space in its name should not be allowed to create in a puppet class.
2. There should be a proper error message displayed saying space not allowed in variable name.

Additional info:
Comment 3 Bryan Kearney 2015-11-24 11:06:35 EST
Connecting redmine issue http://projects.theforeman.org/issues/12577 from this bug
Comment 4 Bryan Kearney 2015-11-24 12:06:16 EST
Upstream bug component is Provisioning
Comment 5 Bryan Kearney 2015-12-17 02:05:31 EST
Upstream bug assigned to orabin@redhat.com
Comment 6 Bryan Kearney 2015-12-17 02:05:33 EST
Upstream bug assigned to orabin@redhat.com
Comment 7 Bryan Kearney 2016-01-12 06:07:25 EST
Moving to POST since upstream bug http://projects.theforeman.org/issues/12577 has been closed
Ori Rabin
Applied in changeset commit:54188a7c45c79df42387cba7025b2e7f9a3fbe2a.
Comment 8 Jitendra Yejare 2016-01-27 07:38:39 EST
This issue is still reproducible in upstream.

Build : foreman-1.11.0-0.develop.201601251557git59dc77b.el6.noarch
Comment 10 Jitendra Yejare 2016-03-14 06:38:28 EDT
The issue is reproducible in latest Satellite 6.2 snap 3.
I can create a smart var with blank space in it and also after creating the smart var is not view-able, editable, delatable from Configure -> Classes -> class -> Smart variable.
Comment 11 orabin 2016-03-14 09:07:05 EDT
The smart variable won't be saved, the issue here is that you can't see the validation message.
I created another upstream issue for the hidden validation: http://projects.theforeman.org/issues/14183.
Comment 16 Jitendra Yejare 2016-05-19 08:45 EDT
Created attachment 1159463 [details]
[Verified] Screenshot Attached
Comment 17 Jitendra Yejare 2016-05-19 08:46:11 EDT
Verified !
@Sat 6.2 Snap 11

While adding/updating a smart variable with white space in key name, the error shown as "Can't contain spaces.". This is an expected behavior.

The verification Screenshot attached.
Comment 18 Bryan Kearney 2016-07-27 07:22:27 EDT
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.