Bug 1284820 - No error printed when creating a lifecycle environment with the same name in step 1C
No error printed when creating a lifecycle environment with the same name in ...
Product: Red Hat Quickstart Cloud Installer
Classification: Red Hat
Component: WebUI (Show other bugs)
Unspecified Unspecified
unspecified Severity unspecified
: TP2
: 1.0
Assigned To: Dylan Murray
Dave Johnson
: Triaged
Depends On:
Blocks: rhci-sprint-12
  Show dependency treegraph
Reported: 2015-11-24 04:50 EST by Antonin Pagac
Modified: 2016-10-03 15:00 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2016-10-03 15:00:27 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Antonin Pagac 2015-11-24 04:50:39 EST
Description of problem:
While doing a deployment, in step 1C "Configure Lifecycle Environment" I choose to create new environment path by clicking on a button "New Environment Path". In the dialog I then choose a name and submitted, this worked fine. I then clicked on the "New Environment Path" button again, creating and submitting environment path with the same name as before, no error or warning appeared. I clicked the Next button, got to step 1D "Access Insights" and this error appeared under my deployment name:

error saving environmentError: The backend rejected the commit because it was invalid: {name: of environment must be unique within one organization, label: of environment must be unique within one organization}

We should check if the name of a created environment path is unique, and if not, we should print a warning/error preferably in the New Environment Path pop-up dialog. For example, checking deployment name is implemented this way.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. Start a new deployment, go to step 1C
2. Choose to create New Environment Path, submit a valid name
3. Choose to create New Environment Path again, submit the same name as before, no error appears
4. Click Next, in step 1D the above error appears

Actual results:
I got to next step before seeing an error about the unique environment path name

Expected results:
I should see the error in step 1C, I should not be allowed to submit environment path with non-unique name

Additional info:
Comment 1 Dylan Murray 2016-01-11 16:37:52 EST
PR: https://github.com/fusor/fusor/pull/614

Added check before environment name is saved which would cause problems if the names are not unique because it tries overwriting the . Now an error is printed on 1C explaining that the environment name is not unique.
Comment 2 Antonin Pagac 2016-01-25 09:19:56 EST


Note You need to log in before you can comment on or make changes to this bug.