RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1284869 - atomic migrate export command doesn't support deleting dangling image
Summary: atomic migrate export command doesn't support deleting dangling image
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: atomic
Version: 7.3
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: rc
: ---
Assignee: smahajan@redhat.com
QA Contact: atomic-bugs@redhat.com
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-11-24 11:18 UTC by Alex Jia
Modified: 2016-03-31 23:25 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-03-31 23:25:21 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:0527 0 normal SHIPPED_LIVE atomic bug fix and enhancement update 2016-04-01 03:20:15 UTC

Description Alex Jia 2015-11-24 11:18:14 UTC 
Description of problem:
Atomic migrate command cann't deal with regular expressions, for example, for a dangling images, it will raise shell syntax error.

Version-Release number of selected component (if applicable):
# rpm -q docker atomic
docker-1.9.0-9.el7.x86_64
atomic-1.7-2.git68be076.el7.x86_64

# cat /etc/redhat-release 
Red Hat Enterprise Linux Server release 7.1 (Maipo)

How reproducible:
always

Steps to Reproduce:
1. build a image to generate a dangling image
2. run atomic migrate export

Actual results:
# atomic images
 REPOSITORY                          TAG                 IMAGE ID            CREATED             VIRTUAL SIZE
 registry.access.redhat.com/openshift3/ose latest              2eb816e9a7d0        2015-11-12 05:29    395.32 MB   
 docker-registry.usersys.redhat.com/baude/oscapd latest              69871a5c7067        2015-10-29 07:38    909.87 MB   
*<none>                              <none>              63b155fb8278        2015-10-27 16:13    1.11 MB 

# atomic migrate export
Exporting image with id: 2eb816e9a7d0
Exporting image with id: 63b155fb8278
/bin/sh: -c: line 0: syntax error near unexpected token `>'
/bin/sh: -c: line 0: `docker save <none>:<none> > /var/lib/atomic/migrate/images/63b155fb8278.tar'
<class 'subprocess.CalledProcessError'>


Expected results:
Fix it or doesn't support saving dangling image

Additional info:
Comment 1 Daniel Walsh 2015-11-24 16:35:50 UTC 
I don't think we should save dangling images.
Comment 2 Alex Jia 2015-11-25 03:07:27 UTC 
(In reply to Daniel Walsh from comment #1)
> I don't think we should save dangling images.

Yes, I think we have 2 ways to do this, the one is users must manually remove dangling images before migrating, and then it should be enough to document it in man page or help document; the other one is to let atomic migrate command more intelligent then can bypass or remove dangling images to do export, I tend to choose latter, it will be more convenient to migrate multiple docker containers own dangling images for users.
Comment 3 Daniel Walsh 2015-11-25 13:16:15 UTC 
Perhaps the tool could either exit with an error if their are dangling images, or prompt the user to ask permission to delete the <none><none>
Comment 4 Daniel Walsh 2016-01-06 19:17:02 UTC 
Shishir please comment.
Comment 5 smahajan@redhat.com 2016-01-06 19:21:44 UTC 
There was already a check to ignore dangling images (<none>:<none>) from getting exported. Let me check why it is not working.

Shishir
Comment 6 smahajan@redhat.com 2016-01-15 19:15:46 UTC 
This is fixed in atomic master branch.
Closing this.

Shishir
Comment 7 Daniel Walsh 2016-01-15 19:24:54 UTC 
You need to tell the version

Fixed in atomic-1.9.
Comment 9 Alex Jia 2016-01-21 04:09:21 UTC 
With atomic-1.8-4.git958d939.el7.x86_64, I can get a prompt information like this "There are dangling images in your system. Would you like atomic to prune them [y/N]" when migrating storage w/ dangling image, and it works well w/ 'y' and 'N' typing, so move the bug to VERIFIED status.
Comment 11 errata-xmlrpc 2016-03-31 23:25:21 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-0527.html
Note You need to log in before you can comment on or make changes to this bug.