Bug 1285082 - grubby: incorrect handling of separator in grub set variable value
grubby: incorrect handling of separator in grub set variable value
Status: CLOSED EOL
Product: Fedora
Classification: Fedora
Component: grubby (Show other bugs)
22
Unspecified Linux
unspecified Severity high
: ---
: ---
Assigned To: Peter Jones
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2015-11-24 15:42 EST by rhbug
Modified: 2016-07-19 15:22 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2016-07-19 15:22:47 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description rhbug 2015-11-24 15:42:34 EST
Description of problem:

In /etc/sysconfig/grub I have:

GRUB_GFXPAYLOAD_LINUX="vga=normal"

Which is probably incorrect but it leads to some interesting behaviour:

grub2-mkconfig adds this line to menu entries:

        set gfxpayload=vga=normal

then when grubby runs it changes it to 

        set gfxpayload=vga=normal=normal=normal.. and so on

repeating '=normal' 26795 times resulting a 187585 characters long line. The rest of the file looks fine.


When trying to boot with this config, grub prints an error message and immediately reboots, without any possibility to recover.


Version-Release number of selected component (if applicable):

grubby-8.40-1.fc22.x86_64


How reproducible:


Steps to Reproduce:
1. Make sure you have some way to revert your grub.cfg without needing the grub you are trying this on
2. Add "set gfxpayload=vga=normal" (without the quotes) to one of your menuentry sections
3. Install or remove a kernel using dnf


Actual results:

The resulting grub.conf contains a long line of repeated '=normal'.
Inability to boot or even get to grub command line.


Expected results:

No long lines of repeated '=normal'.
Booting just fine.


Additional info:

This bug was already present in f21.
Comment 1 Fedora End Of Life 2016-07-19 15:22:47 EDT
Fedora 22 changed to end-of-life (EOL) status on 2016-07-19. Fedora 22 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

Note You need to log in before you can comment on or make changes to this bug.