Bug 1286959 - [GlusterD]: After log rotate of cmd_history.log file, the next executed gluster commands are not present in the cmd_history.log file.
Summary: [GlusterD]: After log rotate of cmd_history.log file, the next executed glus...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: glusterd
Version: mainline
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Satish Mohan
QA Contact:
URL:
Whiteboard: glusterd
Depends On:
Blocks: 1276219 1304963
TreeView+ depends on / blocked
 
Reported: 2015-12-01 08:53 UTC by Gaurav Kumar Garg
Modified: 2016-06-16 13:47 UTC (History)
7 users (show)

Fixed In Version: glusterfs-3.8rc2
Clone Of: 1276219
: 1304963 (view as bug list)
Environment:
Last Closed: 2016-06-16 13:47:31 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:

Attachments (Terms of Use)

Comment 1 Vijay Bellur 2015-12-01 11:15:26 UTC 
REVIEW: http://review.gluster.org/12832 (libglusterfs: close & open cmd_history.log on log rotate) posted (#5) for review on master by Gaurav Kumar Garg (ggarg)
Comment 2 Vijay Bellur 2015-12-01 11:24:35 UTC 
REVIEW: http://review.gluster.org/12832 (libglusterfs: close & open cmd_history.log on log rotate) posted (#6) for review on master by Gaurav Kumar Garg (ggarg)
Comment 3 Vijay Bellur 2015-12-03 07:20:45 UTC 
REVIEW: http://review.gluster.org/12832 (libglusterfs: close & open cmd_history.log on log rotate) posted (#7) for review on master by Gaurav Kumar Garg (ggarg)
Comment 4 Vijay Bellur 2016-02-01 07:49:59 UTC 
REVIEW: http://review.gluster.org/12832 (libglusterfs: close & open cmd_history.log on log rotate) posted (#8) for review on master by Gaurav Kumar Garg (ggarg)
Comment 5 Vijay Bellur 2016-02-04 21:51:57 UTC 
COMMIT: http://review.gluster.org/12832 committed in master by Niels de Vos (ndevos) 
------
commit 8fdfa0c17cf492f39e675f7502596754f6e5aeb4
Author: Gaurav Kumar Garg <garg.gaurav52>
Date:   Tue Dec 1 14:23:08 2015 +0530

    libglusterfs: close & open cmd_history.log on log rotate
    
    Post log rotate, cmd_history.log is not refreshed (closed & opened back)
    due to which new commands still land up in the log rotated file.
    
    Fix is to close and open cmd_history.log file upon log rotation
    
    Change-Id: Ie6990c9d55b0afa544bc5c84de3db49ff4b1299b
    BUG: 1286959
    Signed-off-by: Gaurav Kumar Garg <ggarg>
    Reviewed-on: http://review.gluster.org/12832
    Smoke: Gluster Build System <jenkins.com>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>
    NetBSD-regression: NetBSD Build System <jenkins.org>
Comment 6 Vijay Bellur 2016-03-28 05:24:15 UTC 
REVIEW: http://review.gluster.org/13829 (libglusterfs: open cmd_history log file with O_APPEND) posted (#1) for review on master by Atin Mukherjee (amukherj)
Comment 7 Vijay Bellur 2016-03-29 05:08:52 UTC 
REVIEW: http://review.gluster.org/13829 (libglusterfs: open cmd_history log file with O_APPEND and O_RDWR) posted (#2) for review on master by Atin Mukherjee (amukherj)
Comment 8 Vijay Bellur 2016-03-29 09:15:34 UTC 
REVIEW: http://review.gluster.org/13829 (libglusterfs: open cmd_history log file with O_APPEND and O_WRONLY) posted (#3) for review on master by Atin Mukherjee (amukherj)
Comment 9 Vijay Bellur 2016-03-29 19:10:50 UTC 
COMMIT: http://review.gluster.org/13829 committed in master by Jeff Darcy (jdarcy) 
------
commit 207289621f6c5b75bdb80aa14ddaf72efd5eb9b1
Author: Atin Mukherjee <amukherj>
Date:   Mon Mar 28 10:49:43 2016 +0530

    libglusterfs: open cmd_history log file with O_APPEND and O_WRONLY
    
    Commit 8fdfa0c introduced a fix to ensure cmd_history file is log rotated
    properly. However with this fix fdopen() is called with mode "a" on a fd which
    was not opened with O_WRONLY & O_APPEND resulting into a fdopen() failure.
    
    Fix is to open cmd_history.log file with O_CREATE|O_WRONLY|O_APPEND mode
    
    Change-Id: I75ef350560aa6d5435c78c5fd83adfde1a73bfc3
    BUG: 1286959
    Signed-off-by: Atin Mukherjee <amukherj>
    Reviewed-on: http://review.gluster.org/13829
    Smoke: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
Comment 12 Niels de Vos 2016-06-16 13:47:31 UTC 
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user
Note You need to log in before you can comment on or make changes to this bug.