1287320 – When referencing a stonith/resource agent without a provider and the fence/resource agents fails to get metadata causes pcs to traceback

RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1287320 - When referencing a stonith/resource agent without a provider and the fence/resource agents fails to get metadata causes pcs to traceback

Summary: When referencing a stonith/resource agent without a provider and the fence/re...

Keywords:
Status:	CLOSED ERRATA
Alias:	None
Product:	Red Hat Enterprise Linux 7
Classification:	Red Hat
Component:	pcs
Sub Component:
Version:	7.3
Hardware:	Unspecified
OS:	Unspecified
Priority:	medium
Severity:	low
Target Milestone:	rc
Target Release:	---
Assignee:	Ivan Devat
QA Contact:	cluster-qe@redhat.com
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+	depends on / blocked

Reported:	2015-12-01 23:37 UTC by Chris Feist
Modified:	2016-11-03 20:55 UTC (History)
CC List:	4 users (show)
Fixed In Version:	pcs-0.9.151-1.el7
Doc Type:	Bug Fix
Doc Text:	Cause: fence agent is bad (or errors out), when trying get metadata from it Consequence: pcs crashes with exception traceback, when trying build error message Fix: correct error message building Result: pcs exits gracefully with explanatory error message
Clone Of:
Environment:
Last Closed:	2016-11-03 20:55:58 UTC
Target Upstream Version:
Embargoed:

Attachments	(Terms of Use)

Links
System	ID	Private	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHSA-2016:2596	0	normal	SHIPPED_LIVE	Moderate: pcs security, bug fix, and enhancement update	2016-11-03 12:11:34 UTC

Description Chris Feist 2015-12-01 23:37:58 UTC

Description of problem:
pcs tracebacks when in validInstanceAttributes if the fence agent is bad (or errors out).

Version-Release number of selected component (if applicable):
pcs-0.9.143-15.el7.x86_64

How reproducible:
Always

Steps to Reproduce:
1. pcs stonith update <fa name> #(where ra name is the id of a bad fence agent)

Actual results:
Traceback

Expected results:
Proper Error

Additional info:
[root@overcloud-controller-0 heat-admin]# pcs stonith update fence-nova verbose=false
Traceback (most recent call last):
  File "/sbin/pcs", line 219, in <module>
    main(sys.argv[1:])
  File "/sbin/pcs", line 159, in main
    cmd_map[command](argv)
  File "/usr/lib/python2.7/site-packages/pcs/stonith.py", line 40, in stonith_cmd
    resource.resource_update(stn_id,argv)
  File "/usr/lib/python2.7/site-packages/pcs/resource.py", line 887, in resource_update
    bad_opts, missing_req_opts = utils.validInstanceAttributes(res_id, params, resource_type)
  File "/usr/lib/python2.7/site-packages/pcs/utils.py", line 1757, in validInstanceAttributes
    err("Unable to find resource: ocf:%s:%s" % (resProvider, resType))
UnboundLocalError: local variable 'resProvider' referenced before assignment


If len(resSplit) == 2, then we never set resProvider and the code traces back in balidInstanceAttributes in utils.py.

Comment 1 Ivan Devat 2016-02-04 07:42:18 UTC

proposed fix:
https://github.com/feist/pcs/commit/feb21ac50f1bc64344e20485b96c2ebd2a7d8a0d

Setup:
[vm-rhel72-1 ~] $ pcs stonith create xvm-fencing fence_xvm pcmk_host_list="vm-rhel72-1 vm-rhel72-2"
[vm-rhel72-1 ~] $ pcs stonith
 xvm-fencing    (stonith:fence_xvm):    Started vm-rhel72-2
[vm-rhel72-1 ~] $ mv /usr/sbin/fence_xvm /usr/sbin/fence_xvm_tmp

Test:
[vm-rhel72-1 ~] $ pcs stonith update xvm-fencing verbose=false
Error: Unable to get metadata for resource: stonith:fence_xvm

Cleanup:
[vm-rhel72-1 ~] $ mv /usr/sbin/fence_xvm_tmp /usr/sbin/fence_xvm
[vm-rhel72-1 ~] $ pcs stonith delete xvm-fencing
Attempting to stop: xvm-fencing...Stopped

Comment 2 Mike McCune 2016-03-28 22:42:18 UTC

This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions

Comment 3 Ivan Devat 2016-05-31 11:55:55 UTC

Before fix:
[vm-rhel72-1 ~] $ rpm -q pcs
pcs-0.9.143-15.el7.x86_64
[vm-rhel72-1 ~] $ pcs stonith create xvm-fencing fence_xvm pcmk_host_list="vm-rhel72-1 vm-rhel72-2"
[vm-rhel72-1 ~] $ pcs stonith
 xvm-fencing    (stonith:fence_xvm):    Started vm-rhel72-1
[vm-rhel72-1 ~] $  mv /usr/sbin/fence_xvm /usr/sbin/fence_xvm_tmp
[vm-rhel72-1 ~] $ pcs stonith update xvm-fencing verbose=false
Traceback (most recent call last):
  File "/usr/sbin/pcs", line 219, in <module>
      main(sys.argv[1:])
    File "/usr/sbin/pcs", line 159, in main
      cmd_map[command](argv)
    File "/usr/lib/python2.7/site-packages/pcs/stonith.py", line 40, in stonith_cmd
      resource.resource_update(stn_id,argv)
    File "/usr/lib/python2.7/site-packages/pcs/resource.py", line 887, in resource_update
      bad_opts, missing_req_opts = utils.validInstanceAttributes(res_id, params, resource_type)
    File "/usr/lib/python2.7/site-packages/pcs/utils.py", line 1757, in validInstanceAttributes
      err("Unable to find resource: ocf:%s:%s" % (resProvider, resType))
  UnboundLocalError: local variable 'resProvider' referenced before assignment

After Fix:
[vm-rhel72-1 ~] $ rpm -q pcs
pcs-0.9.151-1.el7.x86_64
[vm-rhel72-1 ~] $ pcs stonith create xvm-fencing fence_xvm pcmk_host_list="vm-rhel72-1 vm-rhel72-2"
[vm-rhel72-1 ~] $ pcs stonith
 xvm-fencing    (stonith:fence_xvm):    Started vm-rhel72-1
[vm-rhel72-1 ~] $  mv /usr/sbin/fence_xvm /usr/sbin/fence_xvm_tmp
[vm-rhel72-1 ~] $ pcs stonith update xvm-fencing verbose=false
Error: fence agent 'fence_xvm' not found, use --force to override

Comment 7 errata-xmlrpc 2016-11-03 20:55:58 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-2596.html

Note You need to log in before you can comment on or make changes to this bug.