Bug 1287566 - Python-3.1.1-rpath.patch
Summary: Python-3.1.1-rpath.patch
Alias: None
Product: Fedora
Classification: Fedora
Component: python3
Version: rawhide
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Python Maintainers
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: 1287556
TreeView+ depends on / blocked
Reported: 2015-12-02 11:04 UTC by Robert Kuska
Modified: 2019-04-23 15:05 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2017-08-07 16:35:30 UTC
Type: Bug

Attachments (Terms of Use)

Description Robert Kuska 2015-12-02 11:04:41 UTC
From python3.spec:

# Fixup distutils/unixccompiler.py to remove standard library path from rpath:
# Was Patch0 in ivazquez' python3000 specfile:

This patch removes LIBDIR from rpath if rpath contains it.

Interesting reading about rpath from debian:

Fedora packaging guidelines:

Comment 1 Robert Kuska 2015-12-02 11:11:35 UTC
This check should be covered by rpmlint which MUST be run during the review so I propose to drop this patch.

Comment 2 Toshio Ernie Kuratomi 2015-12-04 16:24:31 UTC
I would recommend against dropping the patch.  Since it's only removing LIBDIR, it's removing an rpath that should never be needed (the dynamic linker will try LIBDIR on its own, no need for an rpath to make it do so).  The patch means that distutils does not add the unneeded rpath to any binaries it generates which is what that Debian page recommends (patch the build system).  If we were to drop the patch, then package maintainers of C extensions would need to add boilerplate to their packages which strips the unnecessary rpath.  Better to do that in a single place (the python package) if we can.

If you do decide to drop rpath, you should also coordinate updating all existing C extension packages to include the boilerplate removing rpath.  Python packaging guidelines could also be updated to mention it (but not strictly necessary -- the rpath guidelines cover this... it would just be keeping the information in one place).

Comment 3 Jan Kurik 2016-02-24 14:04:54 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 24 development cycle.
Changing version to '24'.

More information and reason for this action is here:

Comment 5 Fedora End Of Life 2017-07-25 19:35:49 UTC
This message is a reminder that Fedora 24 is nearing its end of life.
Approximately 2 (two) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 24. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '24'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 24 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 6 Tomas Orsava 2017-08-07 16:35:30 UTC
I agree with Toshio's arguments and since Robert no longer wishes to pursue the issue, I'm closing this bug.

Comment 7 Miro Hrončok 2019-04-23 14:49:26 UTC
As a counterargument, our Python build macros can do the boilerplate for us.

Comment 8 Victor Stinner 2019-04-23 15:05:14 UTC
Follow-up: I proposed the change upstream: https://bugs.python.org/issue36659

Note You need to log in before you can comment on or make changes to this bug.