Bug 1287593 - [gtk3] [dark theme] Adwaita:dark not fully supported
Summary: [gtk3] [dark theme] Adwaita:dark not fully supported
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: libreoffice
Version: 29
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
Assignee: Caolan McNamara
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-12-02 12:02 UTC by Christian Stadelmann
Modified: 2019-11-27 18:11 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-11-27 18:11:43 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Document Foundation 127583 0 None None None 2019-09-16 20:23:30 UTC

Description Christian Stadelmann 2015-12-02 12:02:44 UTC
Description of problem:
In some UI elements Libreoffice doesn't have complete support for dark Gtk3 themes such as Adwaita:dark

Version-Release number of selected component (if applicable):
libreoffice-5.0.3.2-10.fc23.x86_64

How reproducible:
always

Steps to Reproduce:
1. start libreoffice (gtk3) with dark Adwaita theme
2. use UI

Actual results:
Some UI elements are drawn like on a light Adwaita theme, this includes:
1. Tabs (e.g. in Calc to switch between worksheets; or in Draw to switch between "Layout", "Controls" and "Dimension Lines"). Those tabs appear in light gray font drawn on top of another light to medium gray. Background should be dark gray instead.
2. Sidebar (for "Properties", "Styles and Formatting", "Gallery", "Navigator"): When hovering the buttons they get colors drawn as on Adwaita:light which looks quite weird.
3. Shadows for special cursors, e.g. for "Insert a Text Box" (F2 key in Draw): Both cursor and shadow are drawn in very dark grey or black.
4. Spell checker dialog: Highlighted color (red) is very hard to read, it should be lighter
5. Footer (Status bar?): Many symbols are too dark to read
6. URLs are too hard to read, e.g. in Extension Manager

Comment 1 Christian Stadelmann 2015-12-14 13:09:41 UTC
6. URLs (blue on dark grey) on UI are hard to read. See Tools → Options → Language Settings → Writing aids. There is an URL "Get more dictionaries online".
7. Some toolbars have broken background colors. This affects the "Form Controls" Toolbar in Libreoffice Base. You can see it when you open a database (default: HSQLDB) and open Insert → Form from main menu.
8. In Writer, Impress and Draw rulers are quite hard to read
9. In Writer, Format → Character → Font, the font should be drawn black on white as it will be drawn in the document. Same for tabs "Font Effects", "Position", "Borders". Same for Format → Paragraph (most tabs), Format → Page, Format → Columns, Format → Styles and Formatting, 
10. In Writer, some Toolbar items are hard to see. This affects e.g. the "Omega" button (Special characters, Standard toolbar) and the "Line" (insert line, Standard toolbar)

Comment 2 Caolan McNamara 2016-02-12 15:06:26 UTC
https://cgit.freedesktop.org/libreoffice/core/commit/?id=4cd1c029812155e4e1f80dcf69ea4167edec0130 for points 1 and 2

point 3 "Insert a Text Box" cursor thing is the same in dark and light themes. But the page underneath the cursor is typically the same white, so that seems ok to me.

point 4 That's light red in a bold font. I'm not sure what a fool-proof solution here is. I can't find something theme related that's guaranteed to be a good choice for "error" text.

point 5 and 10 are probably the same problem.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=06e8c58acb6ba667f8fd8c5587a3b3037324971a for point 6

point 7 seems fixed in rawhide

https://cgit.freedesktop.org/libreoffice/core/commit/?id=e6d6e35320984fe4198314e3ea3a91ead6b41392 as a stab at point 8

9 might also point to places where we don't draw the "real" page background color in those previews

Comment 3 Jan Kurik 2016-02-24 15:43:18 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 24 development cycle.
Changing version to '24'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora24#Rawhide_Rebase

Comment 4 Christian Stadelmann 2016-03-01 15:14:47 UTC
(running libreoffice-5.0.5.2-2.fc23.x86_64)

11. In Calc, "Format Cells" dialog:
Tab Numbers: Number is rendered black on dark gray, barely visible

12. In Calc, "Format Cells" dialog:
Tab Alignment: Text on round knob below "Text Orientation", "ABCD" is rendered gray on gray, barely visible

13. In Calc, "Format Cells" dialog:
Tab Borders: Border picker feels broken, probably due to wrong colors too. I am not sure what exactly feels weird, but it is harder to use than with Adwaita:light.

(In reply to Caolan McNamara from comment #2)
> point 3 "Insert a Text Box" cursor thing is the same in dark and light
> themes. But the page underneath the cursor is typically the same white, so
> that seems ok to me.

How about a light cursor with dark shadows on light background? Making both cursor and its shadow dark feels wrong and looks weird.

Comment 5 Christian Stadelmann 2016-06-05 15:45:49 UTC
Now running libreoffice-5.1.3.2-7.fc24.x86_64 with gtk3-3.20.6-1.fc24.x86_64 on a fully updated Fedora 24.

Summary of all issues above plus 2 new ones, updated list:
1. gone (fixed)
2. gone (fixed)
3. Shadows for special cursors, e.g. for "Insert a Text Box" (F2 key in Draw): Both cursor and shadow are drawn in very dark grey or black. (See discussion above)
4. Spell checker dialog: Highlighted color (red) is very hard to read, it should be lighter
5., 10. Footer (Status bar?) and Toolbars: Many symbols are too dark to read, because they are dark gray or black on medium gray.
6. gone (fixed)
7. gone (fixed)
8. In Writer, Impress and Draw rulers are quite hard to read because they are dark gray on medium gray. Situation seems to have improved though (see commit above)
9. In Writer, Format → Character → Font, the font should be drawn black on white as it will be drawn in the document. Same for tabs "Font Effects", "Position", "Borders". Same for Format → Paragraph (most tabs), Format → Page, Format → Columns, Format → Styles and Formatting
10. See 5
11. In Calc, "Format Cells" dialog, Tab "Numbers": Number is rendered black on medium gray, barely visible
12. In Calc, "Format Cells" dialog, Tab "Alignment": Text on round knob below "Text Orientation", "ABCD" is rendered medium gray on medium gray, barely visible, only through its shadow
13. In Calc, "Format Cells" dialog, Tab "Borders" and in Writer, "Format"→"Paragraph", Tab "Borders": Border picker is hard to use due to different background colors for different line styles. When selected, a line has white background, but when deselected, background is dark gray. Furthermore this widget looks like it should have white background as cells have. It feels quite broken, probably due to wrong colors, I am not sure what exactly feels weird, but it is harder to use than with Adwaita:light
14. In Writer, when opening a document marked as read-only, it will show an information bar with this text: "This document is open in read-only mode. [Edit Document] [X]". This infobar is white (or light gray) font on light yellow background and thus barely readable.
15. In Base, open the workbench (or whatever this UI element is called when creating a new database but escaping the wizard): You see different widgets titled with "Database", "Tasks", "Tablets"

Comment 6 Christian Stadelmann 2016-09-28 20:16:14 UTC
Update with new package versions:
libreoffice-gtk3-5.2.2.1-5.fc25.x86_64
gtk3-3.22.0-1.fc25.x86_64

1. gone (fixed)
2. gone (fixed)
3. ok.
4. Spell checker dialog: Highlighted color (red) is very hard to read, it should be lighter
5., 10. Footer (Status bar?) and Toolbars: Many symbols are too dark to read, because they are dark gray or black on medium gray.
6. gone (fixed)
7. gone (fixed)
8. In Writer, Impress and Draw rulers are quite hard to read because they are dark gray on medium gray. Ruler labels are good though.
9. In Writer, Format → Character → Font, the font should be drawn black on white as it will be drawn in the document. Same for tabs "Font Effects", "Position", "Borders". Same for Format → Paragraph (most tabs), Format → Page, Format → Columns, Format → Styles and Formatting
10. See 5
11. In Calc, "Format Cells" dialog, Tab "Numbers": Number is rendered black on medium gray, barely visible
12. In Calc, "Format Cells" dialog, Tab "Alignment": Text on round knob below "Text Orientation", "ABCD" is rendered medium gray on medium gray, barely visible, only through its shadow or after changing rotation.
13. In Calc, "Format Cells" dialog, Tab "Borders" and in Writer, "Format"→"Paragraph", Tab "Borders": Border picker is hard to use due to different background colors for different line styles. When selected, a line has white background, but when deselected, background is dark gray. Furthermore this widget looks like it should have white background as cells have. It feels quite broken, probably due to wrong colors, I am not sure what exactly feels weird, but it is harder to use than with Adwaita:light
14. In Writer, when opening a document marked as read-only, it will show an information bar with this text: "This document is open in read-only mode. [Edit Document] [X]". This infobar is white (or light gray) font on light yellow background and thus barely readable.
15. untested: In Base, open the workbench (or whatever this UI element is called when creating a new database but escaping the wizard): You see different widgets titled with "Database", "Tasks", "Tablets"

Comment 7 Christian Stadelmann 2016-10-16 21:26:26 UTC
16. In Writer, a checkbox or radiobutton form has a white label on white background. This also affects the printer output and any exported PDF file.

17. In Writer, when exporting a writer document with forms into PDF (not PDF1/a, but with forms), the forms are exported with dark theme resulting in a dark background color. This results in broken PDF file look.

Comment 8 Fedora End Of Life 2017-11-16 19:04:15 UTC
This message is a reminder that Fedora 25 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 25. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '25'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 25 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 9 Christian Stadelmann 2017-11-16 23:21:37 UTC
Update on F27, libreoffice 5.4.3.2-1.fc27.x86_64:

1. gone (fixed)

2. gone (fixed)

3. ok.

4. Spell checker dialog: Highlighted color (red) is hard to read, it should be lighter

5., 10. Footer (Status bar?) and Toolbars: Many symbols are too dark to read, because they are dark gray or black on medium gray.

6. gone (fixed)

7. gone (fixed)

8. In Writer, Impress and Draw rulers are hard to read because they are dark gray on medium gray. Ruler labels are ok, but could be lighter.

9. In Writer, Format → Character → Font, the font should be drawn black on white as it will be drawn in the document. Same for tabs "Font Effects", "Position", "Borders". Same for Format → Paragraph (most tabs), Format → Page, Format → Columns, Format → Styles and Formatting

10. See 5

11. In Calc, "Format Cells" dialog, Tab "Numbers": Number is rendered black on medium gray, barely visible

12. In Calc, "Format Cells" dialog, Tab "Alignment": Text on round knob below "Text Orientation", "ABCD" is rendered medium gray on medium gray, barely visible, only through its shadow or after changing rotation.

13. In Calc, "Format Cells" dialog, Tab "Borders" and in Writer, "Format"→"Paragraph", Tab "Borders": Border picker is hard to use due to different background colors for different line styles. When selected, a line has white background, but when deselected, background is dark gray. Furthermore this widget looks like it should have white background as cells have. It feels quite broken, probably due to wrong colors, I am not sure what exactly feels weird, but it is harder to use than with Adwaita:light

14. gone

15. untested: In Base, open the workbench (or whatever this UI element is called when creating a new database but escaping the wizard): You see different widgets titled with "Database", "Tasks", "Tablets"

16. In Writer, a checkbox or radiobutton form has a white label on white background. This also affects the printer output and any exported PDF file.

17. In Writer, when exporting a writer document with forms into PDF (not PDF1/a, but with forms), the forms are exported with dark theme resulting in a dark background color. This results in broken PDF file look.

Comment 10 Caolan McNamara 2017-11-17 10:56:40 UTC
This bug with 17 sprawling items is nigh unfixable

Comment 11 Christian Stadelmann 2018-10-09 22:32:56 UTC
Still present on Fedora 29 Beta.

(In reply to Caolan McNamara from comment #10)
> This bug with 17 sprawling items is nigh unfixable

Should we split it up? Post it upstream? Or should LibreOffice just enforce the light theme variant?

Comment 12 Adolfo Jayme 2018-12-17 20:57:02 UTC
> Should we split it up?

It’s always a good practice to write bug reports which focus on only one issue.

Comment 13 Jean-François Fortin Tam 2019-09-16 20:23:30 UTC
For what it's worth, I have filed a specific issue regarding certain toolbar modes here: https://bugs.documentfoundation.org/show_bug.cgi?id=127583

Comment 14 Ben Cotton 2019-10-31 18:50:15 UTC
This message is a reminder that Fedora 29 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 29 on 2019-11-26.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '29'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 29 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 15 Ben Cotton 2019-11-27 18:11:43 UTC
Fedora 29 changed to end-of-life (EOL) status on 2019-11-26. Fedora 29 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.