Red Hat Bugzilla – Bug 1287723
Handle Rsync/Tar errors effectively
Last modified: 2016-06-16 09:47:58 EDT
Description of problem:
When Changelogs processed in Batch, Geo-rep logs all the GFIDs from that batch as SKIPPED even when a few GFIDs from the batch failed to sync.
Steps to Reproduce: (Reproduced by introducing GFID conflict)
1. Create a file in Slave mount(say f1)
2. Create files in Master mount and add data to it
echo "Hello" > f1; echo "Hello" > f2; echo "Hello" > f3;
3. All the files Create and Data will be recorded in single changelog. Rsync/Tar skips f1 but syncs f2 and f3. But it logs GFIDs of f1, f2 and f3 as SKIPPED.
Logs all the GFIDs as failure.
Only failures should be reported in log.
REVIEW: http://review.gluster.org/12856 (geo-rep: Handling Rsync/Tar errors efficiently) posted (#1) for review on master by Aravinda VK (firstname.lastname@example.org)
REVIEW: http://review.gluster.org/12856 (geo-rep: Handling Rsync/Tar errors efficiently) posted (#2) for review on master by Aravinda VK (email@example.com)
COMMIT: http://review.gluster.org/12856 committed in master by Venky Shankar (firstname.lastname@example.org)
Author: Aravinda VK <email@example.com>
Date: Wed Dec 2 19:37:55 2015 +0530
geo-rep: Handling Rsync/Tar errors efficiently
Geo-rep processes Changelogs in Batch, if one file in batch
fails with rsync error that Changelog file is reprocessed multiple times.
After MAX_RETRY, it logs all the GFIDs from that batch as Skipped.
This patch addresses following issues,
1. When Rsync/Tar fails do not parse Changelog again for retry
2. When Rsync/Tar fails do not replay Entry operations, only retry
rsync/tar for those GFIDs
3. Log Error in Rsync/Tar only in the last Retry
4. Do not log Skipped GFIDs since Rsync/Tar errors are logged for
only failed files.
5. Changed Entry failures as Error instead of Warning
Signed-off-by: Aravinda VK <firstname.lastname@example.org>
Reviewed-by: Kotresh HR <email@example.com>
Reviewed-by: Saravanakumar Arumugam <firstname.lastname@example.org>
CentOS-regression: Gluster Build System <email@example.com>
Smoke: Gluster Build System <firstname.lastname@example.org>
NetBSD-regression: NetBSD Build System <email@example.com>
Reviewed-by: Venky Shankar <firstname.lastname@example.org>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.
glusterfs-3.8.0 has been announced on the Gluster mailinglists , packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist  and the update infrastructure for your distribution.