Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RDO tickets are now tracked in Jira https://issues.redhat.com/projects/RDO/issues/

Bug 1288179

Summary: Mitaka: Packstack image provisioning fails with "Store filesystem could not be configured correctly"
Product: [Community] RDO Reporter: David Moreau Simard <dmsimard>
Component: openstack-packstackAssignee: Ivan Chavero <ichavero>
Status: CLOSED CURRENTRELEASE QA Contact: Shai Revivo <srevivo>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: trunkCC: aortega, apevec, chris.brown, derekh, ichavero, srevivo
Target Milestone: ---   
Target Release: trunk   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openstack-packstack-7.0.0-dev1692.gcf06e35.el7.centos Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-06-18 06:35:08 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
172.19.3.120_provision_glance.log
none
glance/api.log
none
/etc/glance/glance-api.conf
none
Reproducer none

Description David Moreau Simard 2015-12-03 18:49:51 UTC
We have begun testing Packstack on Mitaka with delorean current.

It doesn't look like the parameter filesystem_store_datadir defaults to the sane "/var/lib/glance/images" value anymore and instead now defaults to "None" as per 
https://github.com/openstack/glance/commit/fa30891cf659360207b71d9345666478d4554582

puppet-glance can already configure this properly with https://github.com/openstack/puppet-glance/blob/master/manifests/backend/file.pp but Packstack does not use it according to https://github.com/openstack/packstack/blob/master/packstack/puppet/templates/glance.pp.

If Packstack means to use the file backend, it should include the file backend from puppet-glance.

Relevant logs are attached but full job logs are available here: https://ci.centos.org/artifacts/rdo/jenkins-whayutin-poc-pastack-promote-64

Comment 1 David Moreau Simard 2015-12-03 18:50:19 UTC
Created attachment 1101909 [details]
172.19.3.120_provision_glance.log

Comment 2 David Moreau Simard 2015-12-03 18:51:01 UTC
Created attachment 1101910 [details]
glance/api.log

Comment 3 David Moreau Simard 2015-12-03 18:51:43 UTC
Created attachment 1101911 [details]
/etc/glance/glance-api.conf

Comment 4 David Moreau Simard 2015-12-03 19:57:48 UTC
Worth mentioning that this is a blocker for Mitaka test days due Dec 11th, a fix by then would be nice, otherwise we will need to document a workaround.

Comment 5 Alan Pevec 2015-12-03 22:26:26 UTC
> It doesn't look like the parameter filesystem_store_datadir defaults to the
> sane "/var/lib/glance/images" value anymore and instead now defaults to
> "None" as per 
> https://github.com/openstack/glance/commit/
> fa30891cf659360207b71d9345666478d4554582

There must be more to this, that commit is included since Liberty release 11.0.0 so I'd like to understand how come it works in RDO Liberty.
In openstack-* RPMs, distro defaults from *dist.conf should be applied, there's patch in python-oslo-config to load from /usr/share/<project>/*dist.conf

Regardless, explicitly including file backend is the right thing to do in Packstack manifest, instead of relying on defaults.

Comment 6 David Moreau Simard 2015-12-04 21:05:18 UTC
Created attachment 1102446 [details]
Reproducer

This should be enough to reproduce the issue

Comment 7 David Moreau Simard 2015-12-05 14:42:51 UTC
So there's an actual glance_file.pp file: https://github.com/openstack/packstack/blob/master/packstack/puppet/templates/glance_file.pp

This was introduced with the Swift backend support:
https://github.com/openstack/packstack/commit/3e2bb3d5c93625e57a1840077e895feb81dcf5ba#diff-ccb1620e56ce8c728797f3417f0c0b4f

So is it not applied properly then ?

Comment 8 David Moreau Simard 2015-12-05 15:27:15 UTC
Just confirming that it's not applied properly, I let packstack run - then added the contents of glance_file.pp to glance.pp, ran packstack again and it applied the following config:

Notice: Compiled catalog for test-packstack-mitaka.openstacklocal in environment production in 1.30 seconds
Warning: The package type's allow_virtual parameter will be changing its default value from false to true in a future release. If you do not want to allow virtual packages, please explicitly set allow_virtual to false.
   (at /usr/share/ruby/vendor_ruby/puppet/type.rb:816:in `set_default')
Notice: /Stage[main]/Glance::Backend::File/Glance_api_config[glance_store/default_store]/ensure: created
Notice: /Stage[main]/Glance::Backend::File/Glance_api_config[glance_store/filesystem_store_datadir]/ensure: created
Notice: /Stage[main]/Glance::Backend::File/Glance_cache_config[glance_store/filesystem_store_datadir]/ensure: created
Notice: /Stage[main]/Glance::Db::Sync/Exec[glance-manage db_sync]: Triggered 'refresh' from 3 events
Notice: /Stage[main]/Glance::Registry/Service[glance-registry]: Triggered 'refresh' from 1 events
Notice: /Stage[main]/Glance::Api/Service[glance-api]: Triggered 'refresh' from 4 events
Notice: Finished catalog run in 2.84 seconds

Comment 9 Ivan Chavero 2015-12-07 06:55:11 UTC
Tested with the current OPM master-patches and packstack master and installed succesfully.

Anyway i'm creating a packstack patch for it to explictly apply the glance::backend::file class.

Comment 10 David Moreau Simard 2015-12-07 14:40:00 UTC
@Ivan, can you let me know exactly how you got a successful install ? I can reliably reproduce this every time and included a workaround for the test day: https://gist.github.com/dmsimard/9ba4e52de736adac2ca0#file-packstack-sh-L26-L29

Comment 11 Ivan Chavero 2015-12-08 06:33:02 UTC
just apply this patch: https://review.openstack.org/254431
hopefully we'll get it merged before the test day

Comment 12 Alan Pevec (Fedora) 2015-12-08 13:18:10 UTC
s/hopefully// :)

Comment 13 Mike McCune 2016-03-28 22:42:18 UTC
This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions

Comment 15 Christopher Brown 2017-06-17 16:49:04 UTC
Looks like this was fixed and can be closed?