Red Hat Bugzilla – Bug 1288638
sanlock shared leases are erased on disk
Last modified: 2016-09-29 09:58:01 EDT
Description of problem:
This is a regression in 7.2 that breaks the protection of leases when the shared lease mode is used. It first appeared in sanlock 3.2.3, as a result of this commit:
That commit added a paxos_erase_dblock() call in paxos_lease_release(), which wrongly clears the shared flag in the mode_block that had just been set. Acquiring the shared lease works, and sanlock believes it is held, but on disk the shared flag has been inadvertently cleared by erasing the dblock structure. This means that an exclusive lease requested by another host will not see the shared flag and will succeed.
Two hosts will never be able to hold an exclusive lease concurrently, and an existing exclusive lease can never be acquired shared by another host.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
fix is here
This will be part of the sanlock rebase, bug 1295876.
We (Rhev storage QE) executed our automation using below sanlock pkgs and didn't face anything special.
[root@lynx09 ~]# rpm -qa |grep sanlock