RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Description of problem:

This is a regression in 7.2 that breaks the protection of leases when the shared lease mode is used.  It first appeared in sanlock 3.2.3, as a result of this commit:

https://git.fedorahosted.org/cgit/sanlock.git/commit/?id=e40e1f6e22f9b10f08d53fc7

That commit added a paxos_erase_dblock() call in paxos_lease_release(), which wrongly clears the shared flag in the mode_block that had just been set.  Acquiring the shared lease works, and sanlock believes it is held, but on disk the shared flag has been inadvertently cleared by erasing the dblock structure.  This means that an exclusive lease requested by another host will not see the shared flag and will succeed.

Two hosts will never be able to hold an exclusive lease concurrently, and an existing exclusive lease can never be acquired shared by another host.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

fix is here
https://git.fedorahosted.org/cgit/sanlock.git/commit/?id=ce98f5f8141bdf012caf40046dab7fa69f433fdf

This will be part of the sanlock rebase, bug 1295876.

We (Rhev storage QE) executed our automation using below sanlock pkgs and didn't face anything special.

[root@lynx09 ~]# rpm -qa |grep sanlock
sanlock-lib-3.4.0-1.el7.x86_64
sanlock-3.4.0-1.el7.x86_64
libvirt-lock-sanlock-2.0.0-10.el7.x86_64
sanlock-python-3.4.0-1.el7.x86_64


Closing.